src/x64/code-stubs-x64.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 0551365d1635006252398ab301df1108ad4de7e0..2a962b32f9b38bd4efc30a55b0c00bd2f9b83335 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -4853,7 +4853,7 @@ void CallApiGetterStub::Generate(MacroAssembler* masm) {

__ Push(kScratchRegister); // return value default

__ PushAddress(ExternalReference::isolate_address(isolate()));

__ Push(holder);

- __ Push(Smi::kZero); // should_throw_on_error -> false

+ __ Push(Smi::FromInt(0)); // should_throw_on_error -> false

__ Push(FieldOperand(callback, AccessorInfo::kNameOffset));

__ PushReturnAddressFrom(scratch);

« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »