test/cctest/test-api.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Side-by-side diff isn't available for this file because of its large size.

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index c72f6f6b405599e3170b93b21c7cae1768027d6c..8317a06aa22b5bad9e35296ae02037cef0e44d54 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -151,8 +151,6 @@ UNINITIALIZED_TEST(InitializeAndDisposeMultiple) {

for (int i = 0; i < 3; ++i) CHECK(v8::V8::Dispose());

}

-// Tests that Smi::kZero is set up properly.

-UNINITIALIZED_TEST(SmiZero) { CHECK_EQ(i::Smi::kZero, i::Smi::kZero); }

THREADED_TEST(Handles) {

v8::HandleScope scope(CcTest::isolate());

« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | test/cctest/test-code-stub-assembler.cc » ('j') | no next file with comments »