src/ic/x64/ic-x64.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/ic-x64.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/x64/ic-x64.cc

diff --git a/src/ic/x64/ic-x64.cc b/src/ic/x64/ic-x64.cc

index ef38abd9bb6a8514f0528a253988b0988c6e16bb..d0445a229a8ae2b89f9374ef5bf2975bfe5f137f 100644

--- a/src/ic/x64/ic-x64.cc

+++ b/src/ic/x64/ic-x64.cc

@@ -198,7 +198,7 @@ static void GenerateFastArrayLoad(MacroAssembler* masm, Register receiver,

// Out-of-bounds. Check the prototype chain to see if we can just return

// 'undefined'.

- __ SmiCompare(key, Smi::kZero);

+ __ SmiCompare(key, Smi::FromInt(0));

__ j(less, slow); // Negative keys can't take the fast OOB path.

__ bind(&check_prototypes);

__ movp(scratch, FieldOperand(receiver, HeapObject::kMapOffset));

« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »