src/builtins/builtins-conversion.cc - Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-conversion.cc

Issue 2396353002: Revert "Add Smi::Zero and replace all Smi::FromInt(0) calls" (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-conversion.cc

diff --git a/src/builtins/builtins-conversion.cc b/src/builtins/builtins-conversion.cc

index c229c42ec4bb47fb47a3834cf1c7545e17b496cd..a085b149a3fe085b99631f50e066ace59a65d4bf 100644

--- a/src/builtins/builtins-conversion.cc

+++ b/src/builtins/builtins-conversion.cc

@@ -390,7 +390,7 @@ void Builtins::Generate_ToLength(CodeStubAssembler* assembler) {

assembler->Return(assembler->NumberConstant(kMaxSafeInteger));

assembler->Bind(&return_zero);

- assembler->Return(assembler->SmiConstant(Smi::kZero));

+ assembler->Return(assembler->SmiConstant(Smi::FromInt(0)));

}

« no previous file with comments | « src/builtins/builtins-array.cc ('k') | src/builtins/builtins-dataview.cc » ('j') | no next file with comments »