Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2392443009: reflow comments in core/paint (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
jbroman
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, jfernandez, Manuel Rego, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/paint BUG=563793 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/d9019bdca3200c4bab868422c6d374175555bcc4 Cr-Commit-Position: refs/heads/master@{#423267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2057 lines, -1451 lines) Patch
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 9 chunks +42 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp View 4 chunks +20 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 7 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 23 chunks +84 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxDecorationData.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp View 13 chunks +42 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 23 chunks +98 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ClipPathClipper.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FrameSetPainter.cpp View 5 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 8 chunks +26 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 19 chunks +64 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.h View 1 chunk +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 2 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 6 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImageGrid.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImageGrid.cpp View 4 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImageGridTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h View 4 chunks +30 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 21 chunks +76 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 7 chunks +45 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInfo.h View 4 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 3 chunks +20 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 2 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 6 chunks +32 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 25 chunks +127 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 74 chunks +281 lines, -212 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 7 chunks +26 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.h View 2 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 25 chunks +110 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 13 chunks +28 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 8 chunks +34 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 29 chunks +74 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 1 chunk +36 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.h View 6 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp View 4 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNodeIterator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPhase.h View 5 chunks +24 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h View 2 chunks +28 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 11 chunks +46 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 46 chunks +157 lines, -109 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGClipPainter.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGForeignObjectPainter.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 14 chunks +34 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootPainter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 3 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableRowPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 7 chunks +23 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TextPainter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 4 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainter.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 5 chunks +27 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Nico
Sorry!
4 years, 2 months ago (2016-10-05 18:26:03 UTC) #5
jbroman
lgtm
4 years, 2 months ago (2016-10-05 18:44:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392443009/1
4 years, 2 months ago (2016-10-05 18:48:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392443009/1
4 years, 2 months ago (2016-10-05 19:54:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 20:06:38 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 20:08:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9019bdca3200c4bab868422c6d374175555bcc4
Cr-Commit-Position: refs/heads/master@{#423267}

Powered by Google App Engine
This is Rietveld 408576698