Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: third_party/WebKit/Source/core/paint/LayerClipRecorder.h

Issue 2392443009: reflow comments in core/paint (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/LayerClipRecorder.h
diff --git a/third_party/WebKit/Source/core/paint/LayerClipRecorder.h b/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
index c45a6a43f2a1257480fbacdd36ded4b4c9619cc5..b8e3aca3abc84f52a5b7ad1f2b4daa84cbbc2d14 100644
--- a/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
+++ b/third_party/WebKit/Source/core/paint/LayerClipRecorder.h
@@ -27,17 +27,20 @@ class CORE_EXPORT LayerClipRecorder {
DoNotIncludeSelfForBorderRadius
};
- // Set rounded clip rectangles defined by border radii all the way from the PaintLayerPaintingInfo
- // "root" layer down to the specified layer (or the parent of said layer, in case
- // BorderRadiusClippingRule says to skip self). fragmentOffset is used for multicol, to specify
- // the translation required to get from flow thread coordinates to visual coordinates for a
- // certain column.
- // FIXME: The BorderRadiusClippingRule parameter is really useless now. If we want to skip self,
+ // Set rounded clip rectangles defined by border radii all the way from the
+ // PaintLayerPaintingInfo "root" layer down to the specified layer (or the
+ // parent of said layer, in case BorderRadiusClippingRule says to skip self).
+ // fragmentOffset is used for multicol, to specify the translation required to
+ // get from flow thread coordinates to visual coordinates for a certain
+ // column.
+ // FIXME: The BorderRadiusClippingRule parameter is really useless now. If we
+ // want to skip self,
// why not just supply the parent layer as the first parameter instead?
- // FIXME: The ClipRect passed is in visual coordinates (not flow thread coordinates), but at the
- // same time we pass a fragmentOffset, so that we can translate from flow thread coordinates to
- // visual coordinates. This may look rather confusing/redundant, but it is needed for rounded
- // border clipping. Would be nice to clean up this.
+ // FIXME: The ClipRect passed is in visual coordinates (not flow thread
+ // coordinates), but at the same time we pass a fragmentOffset, so that we can
+ // translate from flow thread coordinates to visual coordinates. This may look
+ // rather confusing/redundant, but it is needed for rounded border clipping.
+ // Would be nice to clean up this.
explicit LayerClipRecorder(
GraphicsContext&,
const LayoutBoxModelObject&,

Powered by Google App Engine
This is Rietveld 408576698