[Media Router] Convert MediaRouter to use GURL for presentation URLs.

Converts content/browser for Presentation API and Media Router APIs to use GURL for presentation URLs.  Updates many, many unit tests.

BUG=632623
Committed: https://crrev.com/7a2c823bd8f66f7ea61f8ade94f5e76f0f32ed74
Cr-Commit-Position: refs/heads/master@{#424037}

[mark a. foltz, 2016-10-05 19:56:52]

Description was changed from

==========
[WIP] Convert to GURL and url::Origin.

BUG=632623
==========

to

==========
[WIP] Convert to GURL.

BUG=632623
==========

[mark a. foltz, 2016-10-05 20:19:17]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 20:20:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mark a. foltz, 2016-10-05 20:20:33]

Description was changed from

==========
[WIP] Convert to GURL.

BUG=632623
==========

to

==========
Converts content/browser for Presentation API and Media Router APIs to use GURL
for presentation URLs.  Updates many, many unit tests.

BUG=632623
==========

[mark a. foltz, 2016-10-05 20:21:02]

mfoltz@chromium.org changed reviewers:
+ imcheng@chromium.org, zhaobin@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:35:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mark a. foltz, 2016-10-05 23:48:22]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 23:48:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:13:06]

Dry run: This issue passed the CQ dry run.

[imcheng, 2016-10-07 00:38:36]

lgtm

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
File
chrome/browser/media/router/create_presentation_connection_request_unittest.cc
(right):

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/create_presentation_connection_request_unittest.cc:28:
presentation_url_(kPresentationUrl) {}
presentation_urls_(kPresentationUrl, 1)

or

presentation_urls_{kPresentationUrl}

then you won't need the SetUp

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_source_helper.cc:23: // TODO(mfoltz): Is
kCastUrnPrefix still used?
Seems not. I only see it and MediaSourceForCastApp used in tests....

[mark a. foltz, 2016-10-07 23:14:09]

mfoltz@chromium.org changed reviewers:
+ dcheng@chromium.org

[mark a. foltz, 2016-10-07 23:14:10]

+dcheng for presentation_type_converters[_unittest].cc

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
File
chrome/browser/media/router/create_presentation_connection_request_unittest.cc
(right):

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/create_presentation_connection_request_unittest.cc:28:
presentation_url_(kPresentationUrl) {}
On 2016/10/07 at 00:38:36, imcheng wrote:
> presentation_urls_(kPresentationUrl, 1)
> 
> or
> 
> presentation_urls_{kPresentationUrl}
> 
> then you won't need the SetUp

Done.

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
File chrome/browser/media/router/media_source_helper.cc (right):

https://codereview.chromium.org/2386633003/diff/120001/chrome/browser/media/r...
chrome/browser/media/router/media_source_helper.cc:23: // TODO(mfoltz): Is
kCastUrnPrefix still used?
On 2016/10/07 at 00:38:36, imcheng wrote:
> Seems not. I only see it and MediaSourceForCastApp used in tests....

Removed, and updated unittests.

[dcheng, 2016-10-07 23:30:41]

LGTM, thanks for cleaning this up

https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
(right):

https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:337:
std::vector<GURL> request1_urls({presentation_url1_});
Nit: Chromium prefers this written as:
std::vector<GURL> request1_urls = {presentation_url1_};

https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

[mark a. foltz, 2016-10-08 00:11:28]

https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
(right):

https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:337:
std::vector<GURL> request1_urls({presentation_url1_});
On 2016/10/07 at 23:30:40, dcheng wrote:
> Nit: Chromium prefers this written as:
> std::vector<GURL> request1_urls = {presentation_url1_};
> 
>
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...

Done.

[zhaobin, 2016-10-08 00:18:26]

On 2016/10/08 00:11:28, mark a. foltz wrote:
>
https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
> File
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/2386633003/diff/140001/chrome/browser/media/r...
>
chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:337:
> std::vector<GURL> request1_urls({presentation_url1_});
> On 2016/10/07 at 23:30:40, dcheng wrote:
> > Nit: Chromium prefers this written as:
> > std::vector<GURL> request1_urls = {presentation_url1_};
> > 
> >
>
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-a...
> 
> Done.

LGTM

[mark a. foltz, 2016-10-08 00:34:05]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-10-08 00:34:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
imcheng@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2386633003/#ps160001
(title: "Respond to dcheng@ comment")

[commit-bot: I haz the power, 2016-10-08 00:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-08 01:35:47]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-10-08 01:38:44]

Description was changed from

==========
Converts content/browser for Presentation API and Media Router APIs to use GURL
for presentation URLs.  Updates many, many unit tests.

BUG=632623
==========

to

==========
Converts content/browser for Presentation API and Media Router APIs to use GURL
for presentation URLs.  Updates many, many unit tests.

BUG=632623

Committed: https://crrev.com/7a2c823bd8f66f7ea61f8ade94f5e76f0f32ed74
Cr-Commit-Position: refs/heads/master@{#424037}
==========

[commit-bot: I haz the power, 2016-10-08 01:38:45]

Patchset 9 (id:??) landed as
https://crrev.com/7a2c823bd8f66f7ea61f8ade94f5e76f0f32ed74
Cr-Commit-Position: refs/heads/master@{#424037}