Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6396)

Unified Diff: chrome/browser/media/router/media_route_unittest.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/router/media_route.h ('k') | chrome/browser/media/router/media_router.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/media_route_unittest.cc
diff --git a/chrome/browser/media/router/media_route_unittest.cc b/chrome/browser/media/router/media_route_unittest.cc
index a1f9ae83c6e9e45ef9af73c20cca75fb6c5b43a5..05dd0d8921c0151e627689f6bceffc641ee532b7 100644
--- a/chrome/browser/media/router/media_route_unittest.cc
+++ b/chrome/browser/media/router/media_route_unittest.cc
@@ -8,42 +8,45 @@
#include "testing/gmock/include/gmock/gmock.h"
namespace {
-const char kRouteId1[] =
+constexpr char kRouteId1[] =
"urn:x-org.chromium:media:route:1/cast-sink1/http://foo.com";
-const char kRouteId2[] =
+constexpr char kRouteId2[] =
"urn:x-org.chromium:media:route:2/cast-sink2/http://foo.com";
+constexpr char kPresentationUrl[] = "http://www.example.com/presentation.html";
} // namespace
namespace media_router {
// Tests the == operator to ensure that only route ID equality is being checked.
TEST(MediaRouteTest, Equals) {
- MediaRoute route1(kRouteId1, MediaSourceForCastApp("DialApp"), "sinkId",
- "Description", false, "", false);
+ const MediaSource& media_source =
+ MediaSourceForPresentationUrl(GURL(kPresentationUrl));
+ MediaRoute route1(kRouteId1, media_source, "sinkId", "Description", false, "",
+ false);
// Same as route1 with different sink ID.
- MediaRoute route2(kRouteId1, MediaSourceForCastApp("DialApp"),
- "differentSinkId", "Description", false, "", false);
+ MediaRoute route2(kRouteId1, media_source, "differentSinkId", "Description",
+ false, "", false);
EXPECT_TRUE(route1.Equals(route2));
// Same as route1 with different description.
- MediaRoute route3(kRouteId1, MediaSourceForCastApp("DialApp"), "sinkId",
- "differentDescription", false, "", false);
+ MediaRoute route3(kRouteId1, media_source, "sinkId", "differentDescription",
+ false, "", false);
EXPECT_TRUE(route1.Equals(route3));
// Same as route1 with different is_local.
- MediaRoute route4(kRouteId1, MediaSourceForCastApp("DialApp"), "sinkId",
- "Description", true, "", false);
+ MediaRoute route4(kRouteId1, media_source, "sinkId", "Description", true, "",
+ false);
EXPECT_TRUE(route1.Equals(route4));
// The ID is different from route1's.
- MediaRoute route5(kRouteId2, MediaSourceForCastApp("DialApp"), "sinkId",
- "Description", false, "", false);
+ MediaRoute route5(kRouteId2, media_source, "sinkId", "Description", false, "",
+ false);
EXPECT_FALSE(route1.Equals(route5));
// Same as route1 with different incognito.
- MediaRoute route6(kRouteId1, MediaSourceForCastApp("DialApp"), "sinkId",
- "Description", true, "", false);
+ MediaRoute route6(kRouteId1, media_source, "sinkId", "Description", true, "",
+ false);
route6.set_incognito(true);
EXPECT_TRUE(route1.Equals(route6));
}
« no previous file with comments | « chrome/browser/media/router/media_route.h ('k') | chrome/browser/media/router/media_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698