Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: chrome/browser/media/router/media_source_helper.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_source_helper.cc
diff --git a/chrome/browser/media/router/media_source_helper.cc b/chrome/browser/media/router/media_source_helper.cc
index 73517d2c9fb12df6b15bdb9076b6e8e246785647..2365cdd9caa0a19eab37a22a437605b513bf66fe 100644
--- a/chrome/browser/media/router/media_source_helper.cc
+++ b/chrome/browser/media/router/media_source_helper.cc
@@ -20,7 +20,6 @@ namespace {
// See: https://www.ietf.org/rfc/rfc3406.txt
constexpr char kTabMediaUrnFormat[] = "urn:x-org.chromium.media:source:tab:%d";
constexpr char kDesktopMediaUrn[] = "urn:x-org.chromium.media:source:desktop";
-constexpr char kCastUrnPrefix[] = "urn:x-com.google.cast:application:";
constexpr char kTabRemotingUrnFormat[] =
"urn:x-org.chromium.media:source:tab_content_remoting:%d";
@@ -40,11 +39,7 @@ MediaSource MediaSourceForDesktop() {
return MediaSource(std::string(kDesktopMediaUrn));
}
-MediaSource MediaSourceForCastApp(const std::string& app_id) {
- return MediaSource(kCastUrnPrefix + app_id);
-}
-
-MediaSource MediaSourceForPresentationUrl(const std::string& presentation_url) {
+MediaSource MediaSourceForPresentationUrl(const GURL& presentation_url) {
return MediaSource(presentation_url);
}
@@ -75,20 +70,13 @@ int TabIdFromMediaSource(const MediaSource& source) {
}
bool IsValidMediaSource(const MediaSource& source) {
- return (TabIdFromMediaSource(source) > 0 ||
- IsDesktopMirroringMediaSource(source) ||
- base::StartsWith(source.id(), kCastUrnPrefix,
- base::CompareCase::SENSITIVE) ||
- IsValidPresentationUrl(source.id()));
-}
-
-std::string PresentationUrlFromMediaSource(const MediaSource& source) {
- return IsValidPresentationUrl(source.id()) ? source.id() : "";
+ return TabIdFromMediaSource(source) > 0 ||
+ IsDesktopMirroringMediaSource(source) ||
+ IsValidPresentationUrl(GURL(source.id()));
}
-bool IsValidPresentationUrl(const std::string& url) {
- GURL gurl(url);
- return gurl.is_valid() && gurl.SchemeIsHTTPOrHTTPS();
+bool IsValidPresentationUrl(const GURL& url) {
+ return url.is_valid() && url.SchemeIsHTTPOrHTTPS();
}
} // namespace media_router
« no previous file with comments | « chrome/browser/media/router/media_source_helper.h ('k') | chrome/browser/media/router/media_source_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698