chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc - Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)

Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mock_screen_availability_listener.cc ('k') | chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

index 9e89d4a625d4f3357d336d96ffbf8b575c7cffae..8ca316cfce96aeff0ab99ed560c520f2fc5f7236 100644

--- a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc

@@ -1082,9 +1082,9 @@ TEST_F(MediaRouterMojoImplTest, RouteMessagesMultipleObservers) {

TEST_F(MediaRouterMojoImplTest, PresentationConnectionStateChangedCallback) {

MediaRoute::Id route_id("route-id");

- const std::string kPresentationUrl("http://foo.fakeUrl");

+ const GURL presentation_url("http://www.example.com/presentation.html");

const std::string kPresentationId("pid");

- content::PresentationSessionInfo connection(kPresentationUrl,

+ content::PresentationSessionInfo connection(presentation_url,

kPresentationId);

MockPresentationConnectionStateChangedCallback callback;

std::unique_ptr<PresentationConnectionStateSubscription> subscription =