chrome/browser/media/router/create_presentation_connection_request.cc - Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/create_presentation_connection_request.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)

Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/create_presentation_connection_request.h ('k') | chrome/browser/media/router/create_presentation_connection_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/create_presentation_connection_request.cc

diff --git a/chrome/browser/media/router/create_presentation_connection_request.cc b/chrome/browser/media/router/create_presentation_connection_request.cc

index a9f1e6298f58f6da0ceaafa1a1a226cf01f9edf2..63337c08b8bc81479ea0ac4bf34b1dee893d4289 100644

--- a/chrome/browser/media/router/create_presentation_connection_request.cc

+++ b/chrome/browser/media/router/create_presentation_connection_request.cc

@@ -6,6 +6,7 @@

#include "chrome/browser/media/router/media_source_helper.h"

#include "chrome/browser/media/router/route_request_result.h"

+#include "url/gurl.h"

using content::PresentationSessionInfo;

using content::PresentationError;

@@ -14,7 +15,7 @@ namespace media_router {

CreatePresentationConnectionRequest::CreatePresentationConnectionRequest(

const RenderFrameHostId& render_frame_host_id,

- const std::string& presentation_url,

+ const GURL& presentation_url,

const GURL& frame_url,

const PresentationSessionSuccessCallback& success_cb,

const PresentationSessionErrorCallback& error_cb)