Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2238)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
index 647d9b1c733615a94f75eab62316eb3a9b99471d..2fe3a8390b1cdc492553d7ec28b915738ccdb962 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
@@ -155,9 +155,9 @@ TEST_F(MediaRouterUITest, RouteCreationTimeoutForDesktop) {
TEST_F(MediaRouterUITest, RouteCreationTimeoutForPresentation) {
CreateMediaRouterUI(&profile_);
- PresentationRequest presentation_request(RenderFrameHostId(0, 0),
- {"https://presentationurl.fakeurl"},
- GURL("https://frameurl.fakeurl"));
+ PresentationRequest presentation_request(
+ RenderFrameHostId(0, 0), {GURL("https://presentationurl.com")},
+ GURL("https://frameurl.fakeurl"));
media_router_ui_->OnDefaultPresentationChanged(presentation_request);
std::vector<MediaRouteResponseCallback> callbacks;
EXPECT_CALL(
@@ -195,8 +195,9 @@ TEST_F(MediaRouterUITest, RouteCreationParametersCantBeCreated) {
TEST_F(MediaRouterUITest, RouteRequestFromIncognito) {
CreateMediaRouterUI(profile_.GetOffTheRecordProfile());
- PresentationRequest presentation_request(
- RenderFrameHostId(0, 0), {"https://fooUrl"}, GURL("https://frameUrl"));
+ PresentationRequest presentation_request(RenderFrameHostId(0, 0),
+ {GURL("https://foo.url.com/")},
+ GURL("https://frameUrl"));
media_router_ui_->OnDefaultPresentationChanged(presentation_request);
EXPECT_CALL(
@@ -487,7 +488,7 @@ TEST_F(MediaRouterUITest, NotFoundErrorOnCloseWithNoSinks) {
"No screens found.");
PresentationRequestCallbacks request_callbacks(expected_error);
create_session_request_.reset(new CreatePresentationConnectionRequest(
- RenderFrameHostId(0, 0), std::string("http://google.com/presentation"),
+ RenderFrameHostId(0, 0), GURL("http://google.com/presentation"),
GURL("http://google.com"),
base::Bind(&PresentationRequestCallbacks::Success,
base::Unretained(&request_callbacks)),
@@ -504,7 +505,7 @@ TEST_F(MediaRouterUITest, NotFoundErrorOnCloseWithNoCompatibleSinks) {
content::PresentationErrorType::PRESENTATION_ERROR_NO_AVAILABLE_SCREENS,
"No screens found.");
PresentationRequestCallbacks request_callbacks(expected_error);
- std::string presentation_url("http://google.com/presentation");
+ GURL presentation_url("http://google.com/presentation");
create_session_request_.reset(new CreatePresentationConnectionRequest(
RenderFrameHostId(0, 0), presentation_url, GURL("http://google.com"),
base::Bind(&PresentationRequestCallbacks::Success,
@@ -519,7 +520,7 @@ TEST_F(MediaRouterUITest, NotFoundErrorOnCloseWithNoCompatibleSinks) {
sinks.emplace_back("sink id", "sink name", MediaSink::GENERIC);
std::vector<GURL> origins;
for (auto* observer : media_sinks_observers_) {
- if (observer->source().id() != presentation_url) {
+ if (observer->source().id() != presentation_url.spec()) {
observer->OnSinksUpdated(sinks, origins);
}
}
@@ -534,7 +535,7 @@ TEST_F(MediaRouterUITest, AbortErrorOnClose) {
PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,
"Dialog closed.");
PresentationRequestCallbacks request_callbacks(expected_error);
- std::string presentation_url("http://google.com/presentation");
+ GURL presentation_url("http://google.com/presentation");
create_session_request_.reset(new CreatePresentationConnectionRequest(
RenderFrameHostId(0, 0), presentation_url, GURL("http://google.com"),
base::Bind(&PresentationRequestCallbacks::Success,
@@ -548,8 +549,10 @@ TEST_F(MediaRouterUITest, AbortErrorOnClose) {
std::vector<MediaSink> sinks;
sinks.emplace_back("sink id", "sink name", MediaSink::GENERIC);
std::vector<GURL> origins;
+ MediaSource::Id presentation_source_id =
+ MediaSourceForPresentationUrl(presentation_url).id();
for (auto* observer : media_sinks_observers_) {
- if (observer->source().id() == presentation_url) {
+ if (observer->source().id() == presentation_source_id) {
observer->OnSinksUpdated(sinks, origins);
}
}
« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_ui.h ('k') | chrome/browser/ui/webui/media_router/query_result_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698