Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: content/browser/presentation/presentation_type_converters.h

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_type_converters.h
diff --git a/content/browser/presentation/presentation_type_converters.h b/content/browser/presentation/presentation_type_converters.h
index 5a3bfb601fc9ca911e69a5e7e3a332827d7c5f0e..9285dfae09ebb676389ee65fdfc7c1fee6c132c6 100644
--- a/content/browser/presentation/presentation_type_converters.h
+++ b/content/browser/presentation/presentation_type_converters.h
@@ -31,8 +31,7 @@ struct TypeConverter<blink::mojom::PresentationSessionInfoPtr,
const content::PresentationSessionInfo& input) {
blink::mojom::PresentationSessionInfoPtr output(
blink::mojom::PresentationSessionInfo::New());
- // TODO(crbug.com/632623): Convert downstream APIs to use GURL
- output->url = GURL(input.presentation_url);
+ output->url = input.presentation_url;
output->id = input.presentation_id;
return output;
}
@@ -43,8 +42,7 @@ struct TypeConverter<content::PresentationSessionInfo,
blink::mojom::PresentationSessionInfoPtr> {
static content::PresentationSessionInfo Convert(
const blink::mojom::PresentationSessionInfoPtr& input) {
- // TODO(crbug.com/632623): Convert downstream APIs to use GURL
- return content::PresentationSessionInfo(input->url.spec(), input->id);
+ return content::PresentationSessionInfo(input->url, input->id);
}
};

Powered by Google App Engine
This is Rietveld 408576698