Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2290)

Unified Diff: content/public/browser/presentation_service_delegate.h

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/presentation_service_delegate.h
diff --git a/content/public/browser/presentation_service_delegate.h b/content/public/browser/presentation_service_delegate.h
index cbe2c5f1cc9c5c64cbc46d32beb5b1cca81c4950..3588faf1ae883ce04c9c506b3d3e572f44252869 100644
--- a/content/public/browser/presentation_service_delegate.h
+++ b/content/public/browser/presentation_service_delegate.h
@@ -15,6 +15,8 @@
#include "content/public/browser/presentation_session.h"
#include "content/public/browser/presentation_session_message.h"
+class GURL;
+
namespace content {
class PresentationScreenAvailabilityListener;
@@ -113,11 +115,10 @@ class CONTENT_EXPORT PresentationServiceDelegate {
// PresentationSessionInfo object.
// If |default_presentation_urls| is empty, the default presentation URLs will
// be cleared and the previously registered callback (if any) will be removed.
- // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
virtual void SetDefaultPresentationUrls(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& default_presentation_urls,
+ const std::vector<GURL>& default_presentation_urls,
const PresentationSessionStartedCallback& callback) = 0;
// Starts a new presentation session. The presentation id of the session will
@@ -130,11 +131,10 @@ class CONTENT_EXPORT PresentationServiceDelegate {
// successfully.
// |error_cb|: Invoked with error reason, if presentation session did not
// start.
- // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
virtual void StartSession(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& presentation_urls,
+ const std::vector<GURL>& presentation_urls,
const PresentationSessionStartedCallback& success_cb,
const PresentationSessionErrorCallback& error_cb) = 0;
@@ -146,11 +146,10 @@ class CONTENT_EXPORT PresentationServiceDelegate {
// |success_cb|: Invoked with session info, if presentation session joined
// successfully.
// |error_cb|: Invoked with error reason, if joining failed.
- // TODO(crbug.com/632623): Use GURL instead of std::string for URLs
virtual void JoinSession(
int render_process_id,
int render_frame_id,
- const std::vector<std::string>& presentation_urls,
+ const std::vector<GURL>& presentation_urls,
const std::string& presentation_id,
const PresentationSessionStartedCallback& success_cb,
const PresentationSessionErrorCallback& error_cb) = 0;
« no previous file with comments | « content/public/browser/presentation_screen_availability_listener.h ('k') | content/public/browser/presentation_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698