Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/media/router/media_source_helper.cc

Issue 2386633003: [Media Router] Convert MediaRouter to use GURL for presentation URLs. (Closed)
Patch Set: Respond to dcheng@ comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/media_source_helper.h" 5 #include "chrome/browser/media/router/media_source_helper.h"
6 6
7 #include <stdio.h> 7 #include <stdio.h>
8 8
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "chrome/browser/media/router/media_source.h" 11 #include "chrome/browser/media/router/media_source.h"
12 #include "chrome/browser/sessions/session_tab_helper.h" 12 #include "chrome/browser/sessions/session_tab_helper.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 namespace media_router { 15 namespace media_router {
16 16
17 namespace { 17 namespace {
18 18
19 // Prefixes used to format and detect various protocols' media source URNs. 19 // Prefixes used to format and detect various protocols' media source URNs.
20 // See: https://www.ietf.org/rfc/rfc3406.txt 20 // See: https://www.ietf.org/rfc/rfc3406.txt
21 constexpr char kTabMediaUrnFormat[] = "urn:x-org.chromium.media:source:tab:%d"; 21 constexpr char kTabMediaUrnFormat[] = "urn:x-org.chromium.media:source:tab:%d";
22 constexpr char kDesktopMediaUrn[] = "urn:x-org.chromium.media:source:desktop"; 22 constexpr char kDesktopMediaUrn[] = "urn:x-org.chromium.media:source:desktop";
23 constexpr char kCastUrnPrefix[] = "urn:x-com.google.cast:application:";
24 constexpr char kTabRemotingUrnFormat[] = 23 constexpr char kTabRemotingUrnFormat[] =
25 "urn:x-org.chromium.media:source:tab_content_remoting:%d"; 24 "urn:x-org.chromium.media:source:tab_content_remoting:%d";
26 25
27 } // namespace 26 } // namespace
28 27
29 MediaSource MediaSourceForTab(int tab_id) { 28 MediaSource MediaSourceForTab(int tab_id) {
30 return MediaSource(base::StringPrintf(kTabMediaUrnFormat, tab_id)); 29 return MediaSource(base::StringPrintf(kTabMediaUrnFormat, tab_id));
31 } 30 }
32 31
33 MediaSource MediaSourceForTabContentRemoting(content::WebContents* contents) { 32 MediaSource MediaSourceForTabContentRemoting(content::WebContents* contents) {
34 DCHECK(contents); 33 DCHECK(contents);
35 return MediaSource(base::StringPrintf(kTabRemotingUrnFormat, 34 return MediaSource(base::StringPrintf(kTabRemotingUrnFormat,
36 SessionTabHelper::IdForTab(contents))); 35 SessionTabHelper::IdForTab(contents)));
37 } 36 }
38 37
39 MediaSource MediaSourceForDesktop() { 38 MediaSource MediaSourceForDesktop() {
40 return MediaSource(std::string(kDesktopMediaUrn)); 39 return MediaSource(std::string(kDesktopMediaUrn));
41 } 40 }
42 41
43 MediaSource MediaSourceForCastApp(const std::string& app_id) { 42 MediaSource MediaSourceForPresentationUrl(const GURL& presentation_url) {
44 return MediaSource(kCastUrnPrefix + app_id);
45 }
46
47 MediaSource MediaSourceForPresentationUrl(const std::string& presentation_url) {
48 return MediaSource(presentation_url); 43 return MediaSource(presentation_url);
49 } 44 }
50 45
51 bool IsDesktopMirroringMediaSource(const MediaSource& source) { 46 bool IsDesktopMirroringMediaSource(const MediaSource& source) {
52 return base::StartsWith(source.id(), kDesktopMediaUrn, 47 return base::StartsWith(source.id(), kDesktopMediaUrn,
53 base::CompareCase::SENSITIVE); 48 base::CompareCase::SENSITIVE);
54 } 49 }
55 50
56 bool IsTabMirroringMediaSource(const MediaSource& source) { 51 bool IsTabMirroringMediaSource(const MediaSource& source) {
57 int tab_id; 52 int tab_id;
(...skipping 10 matching lines...) Expand all
68 int tab_id; 63 int tab_id;
69 if (sscanf(source.id().c_str(), kTabMediaUrnFormat, &tab_id) == 1) 64 if (sscanf(source.id().c_str(), kTabMediaUrnFormat, &tab_id) == 1)
70 return tab_id; 65 return tab_id;
71 else if (sscanf(source.id().c_str(), kTabRemotingUrnFormat, &tab_id) == 1) 66 else if (sscanf(source.id().c_str(), kTabRemotingUrnFormat, &tab_id) == 1)
72 return tab_id; 67 return tab_id;
73 else 68 else
74 return -1; 69 return -1;
75 } 70 }
76 71
77 bool IsValidMediaSource(const MediaSource& source) { 72 bool IsValidMediaSource(const MediaSource& source) {
78 return (TabIdFromMediaSource(source) > 0 || 73 return TabIdFromMediaSource(source) > 0 ||
79 IsDesktopMirroringMediaSource(source) || 74 IsDesktopMirroringMediaSource(source) ||
80 base::StartsWith(source.id(), kCastUrnPrefix, 75 IsValidPresentationUrl(GURL(source.id()));
81 base::CompareCase::SENSITIVE) ||
82 IsValidPresentationUrl(source.id()));
83 } 76 }
84 77
85 std::string PresentationUrlFromMediaSource(const MediaSource& source) { 78 bool IsValidPresentationUrl(const GURL& url) {
86 return IsValidPresentationUrl(source.id()) ? source.id() : ""; 79 return url.is_valid() && url.SchemeIsHTTPOrHTTPS();
87 }
88
89 bool IsValidPresentationUrl(const std::string& url) {
90 GURL gurl(url);
91 return gurl.is_valid() && gurl.SchemeIsHTTPOrHTTPS();
92 } 80 }
93 81
94 } // namespace media_router 82 } // namespace media_router
OLDNEW
« no previous file with comments | « chrome/browser/media/router/media_source_helper.h ('k') | chrome/browser/media/router/media_source_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698