Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-style_chromium.org, jbroman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in Source/bindings/core/v8 BUG=563793 Committed: https://crrev.com/0ce7ace48ceee1ce97b6a2ef3e1fdcc8f295309b Cr-Commit-Position: refs/heads/master@{#422435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+512 lines, -371 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Iterable.h View 4 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Microtask.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 5 chunks +20 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 3 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 5 chunks +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 9 chunks +37 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializationTag.h View 3 chunks +95 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ToV8.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 8 chunks +24 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 4 chunks +20 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 2 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 8 chunks +27 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8StringResource.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8StringResource.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ThrowException.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 5 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 2 months ago (2016-10-03 15:21:07 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-03 15:26:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386173002/1
4 years, 2 months ago (2016-10-03 15:28:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 16:41:00 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 16:43:17 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0ce7ace48ceee1ce97b6a2ef3e1fdcc8f295309b
Cr-Commit-Position: refs/heads/master@{#422435}

Powered by Google App Engine
This is Rietveld 408576698