third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp - Issue 2386173002: reflow comments in Source/bindings/core/v8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

index 7e5f60ac2d09fbbe3699974db4a0fc228e7fc0e3..b04f27386a8bf845f64c78a63825dceafd4ffc9a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

@@ -51,7 +51,9 @@ bool V8HiddenValue::setHiddenValue(ScriptState* scriptState,

bool V8HiddenValue::deleteHiddenValue(ScriptState* scriptState,

v8::Local<v8::Object> object,

v8::Local<v8::String> key) {

- // Actually deleting the value would make force the object into dictionary mode which is unnecessarily slow. Instead, we replace the hidden value with "undefined".

+ // Actually deleting the value would make force the object into dictionary

+ // mode which is unnecessarily slow. Instead, we replace the hidden value with

+ // "undefined".

return v8CallBoolean(object->SetPrivate(

scriptState->context(), v8::Private::ForApi(scriptState->isolate(), key),

v8::Undefined(scriptState->isolate())));