Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
index 9e708e703e3b6f03da37c69d821409e7102f02fc..b59da5112f9ef52a1ba72d1ea5f86e16889dde55 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
@@ -212,14 +212,16 @@ RefPtr<BlobDataHandle> V8ScriptValueDeserializer::getOrCreateBlobDataHandle(
const String& type,
uint64_t size) {
// The containing ssv may have a BDH for this uuid if this ssv is just being
- // passed from main to worker thread (for example). We use those values when creating
- // the new blob instead of cons'ing up a new BDH.
+ // passed from main to worker thread (for example). We use those values when
+ // creating the new blob instead of cons'ing up a new BDH.
//
- // FIXME: Maybe we should require that it work that way where the ssv must have a BDH for any
- // blobs it comes across during deserialization. Would require callers to explicitly populate
- // the collection of BDH's for blobs to work, which would encourage lifetimes to be considered
- // when passing ssv's around cross process. At present, we get 'lucky' in some cases because
- // the blob in the src process happens to still exist at the time the dest process is deserializing.
+ // FIXME: Maybe we should require that it work that way where the ssv must
+ // have a BDH for any blobs it comes across during deserialization. Would
+ // require callers to explicitly populate the collection of BDH's for blobs to
+ // work, which would encourage lifetimes to be considered when passing ssv's
+ // around cross process. At present, we get 'lucky' in some cases because the
+ // blob in the src process happens to still exist at the time the dest process
+ // is deserializing.
// For example in sharedWorker.postMessage(...).
BlobDataHandleMap& handles = m_serializedScriptValue->blobDataHandles();
BlobDataHandleMap::const_iterator it = handles.find(uuid);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698