Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Microtask.h

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // C++ calls into script contexts which are "owned" by blink (created in a 42 // C++ calls into script contexts which are "owned" by blink (created in a
43 // process where WebKit.cpp initializes v8) must declare their type: 43 // process where WebKit.cpp initializes v8) must declare their type:
44 // 44 //
45 // 1. Calls into page/author script from a frame 45 // 1. Calls into page/author script from a frame
46 // 2. Calls into page/author script from a worker 46 // 2. Calls into page/author script from a worker
47 // 3. Calls into internal script (typically setup/teardown work) 47 // 3. Calls into internal script (typically setup/teardown work)
48 // 48 //
49 // Debug-time checking of this is enforced via v8::MicrotasksScope. 49 // Debug-time checking of this is enforced via v8::MicrotasksScope.
50 // 50 //
51 // Calls of type (1) should generally go through ScriptController, as inspector 51 // Calls of type (1) should generally go through ScriptController, as inspector
52 // instrumentation is needed. ScriptController allocates V8RecursionScope for yo u. 52 // instrumentation is needed. ScriptController allocates V8RecursionScope for
53 // you.
53 // 54 //
54 // Calls of type (2) should always stack-allocate a v8::MicrotasksScope(kRunMicr toasks) 55 // Calls of type (2) should always stack-allocate a
55 // in the same block as the call into script. 56 // v8::MicrotasksScope(kRunMicrtoasks) in the same block as the call into
57 // script.
56 // 58 //
57 // Calls of type (3) should stack allocate a v8::MicrotasksScope(kDoNotRunMicrot asks) -- 59 // Calls of type (3) should stack allocate a
58 // this skips work that is spec'd to happen at the end of the outer-most 60 // v8::MicrotasksScope(kDoNotRunMicrotasks) -- this skips work that is spec'd to
59 // script stack frame of calls into page script: 61 // happen at the end of the outer-most script stack frame of calls into page
62 // script:
60 // http://www.whatwg.org/specs/web-apps/current-work/#perform-a-microtask-checkp oint 63 // http://www.whatwg.org/specs/web-apps/current-work/#perform-a-microtask-checkp oint
61 class CORE_EXPORT Microtask { 64 class CORE_EXPORT Microtask {
62 STATIC_ONLY(Microtask); 65 STATIC_ONLY(Microtask);
63 66
64 public: 67 public:
65 static void performCheckpoint(v8::Isolate*); 68 static void performCheckpoint(v8::Isolate*);
66 69
67 // TODO(jochen): Make all microtasks pass in the ScriptState they want to be 70 // TODO(jochen): Make all microtasks pass in the ScriptState they want to be
68 // executed in. Until then, all microtasks have to keep track of their 71 // executed in. Until then, all microtasks have to keep track of their
69 // ScriptState themselves. 72 // ScriptState themselves.
70 static void enqueueMicrotask(std::unique_ptr<WTF::Closure>); 73 static void enqueueMicrotask(std::unique_ptr<WTF::Closure>);
71 }; 74 };
72 75
73 } // namespace blink 76 } // namespace blink
74 77
75 #endif // Microtask_h 78 #endif // Microtask_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698