third_party/WebKit/Source/bindings/core/v8/ToV8.h - Issue 2386173002: reflow comments in Source/bindings/core/v8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8.h

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ToV8.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8.h b/third_party/WebKit/Source/bindings/core/v8/ToV8.h

index ddb16cee674f3c329a88344edaeb6b5796e24a40..8771fbde1d06ffcc57293accdfead5b14092596c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ToV8.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8.h

@@ -316,7 +316,8 @@ v8::Local<v8::Value> toV8(void* value,

v8::Local<v8::Object> creationContext,

v8::Isolate*) = delete;

-// Cannot define in ScriptValue because of the circular dependency between toV8 and ScriptValue

+// Cannot define in ScriptValue because of the circular dependency between toV8

+// and ScriptValue

template <typename T>

inline ScriptValue ScriptValue::from(ScriptState* scriptState, T&& value) {

return ScriptValue(scriptState, toV8(std::forward<T>(value), scriptState));