third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp - Issue 2386173002: reflow comments in Source/bindings/core/v8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

index 5f572056f3ede411b027de4bfc77133d471bfe7c..d782e5a2ab816bd76825718e8cf2c863e1816c2d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

@@ -240,7 +240,8 @@ bool ScriptCustomElementDefinition::runConstructor(Element* element) {

if (tryCatch.HasCaught())

return false;

- // To report InvalidStateError Exception, when the constructor returns some different object

+ // To report InvalidStateError Exception, when the constructor returns some

+ // different object

if (result != element) {

const String& message =

"custom element constructors must call super() first and must "