Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

Issue 2386173002: reflow comments in Source/bindings/core/v8 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
index dc43f92a663eaf067698c1cb6e597b10c9472fa0..8b4de0fe51fef6ce31c269f7e5afa4b9f18e58f4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
@@ -39,7 +39,8 @@
namespace blink {
-// Save the state value to a hidden attribute in the V8PopStateEvent, and return it, for convenience.
+// Save the state value to a hidden attribute in the V8PopStateEvent, and return
+// it, for convenience.
static v8::Local<v8::Value> cacheState(ScriptState* scriptState,
v8::Local<v8::Object> popStateEvent,
v8::Local<v8::Value> state) {
@@ -76,11 +77,13 @@ void V8PopStateEvent::stateAttributeGetterCustom(
return;
}
- // There's no cached value from a previous invocation, nor a state value was provided by the
- // event, but there is a history object, so first we need to see if the state object has been
- // deserialized through the history object already.
- // The current history state object might've changed in the meantime, so we need to take care
- // of using the correct one, and always share the same deserialization with history.state.
+ // There's no cached value from a previous invocation, nor a state value was
+ // provided by the event, but there is a history object, so first we need to
+ // see if the state object has been deserialized through the history object
+ // already.
+ // The current history state object might've changed in the meantime, so we
+ // need to take care of using the correct one, and always share the same
+ // deserialization with history.state.
bool isSameState = history->isSameAsCurrentState(event->serializedState());

Powered by Google App Engine
This is Rietveld 408576698