Add Smi::Zero and replace all Smi::FromInt(0) calls

Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Committed: https://crrev.com/9ef4c3af2502d2f6757ffc0c0ff67242d49f7521
Cr-Original-Commit-Position: refs/heads/master@{#40080}
Cr-Commit-Position: refs/heads/master@{#40087}

[jgruber, 2016-09-29 09:42:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 09:43:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-09-29 10:09:57]

jgruber@chromium.org changed reviewers:
+ bmeurer@chromium.org, mstarzinger@chromium.org

[jgruber, 2016-09-29 10:09:58]

Just an idea to improve readability. I know I get annoyed every time I have to
type Smi::FromInt(0).

We could also either make Smi::Zero() constexpr, or just have it return a static
member of Smi.

WDYT?

[commit-bot: I haz the power, 2016-09-29 10:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 10:20:03]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-09-29 11:19:47]

I don't really care, I guess this is something that you'd want to bring up on
v8-team-muc@ for feedback from everyone (that cares).

[Michael Starzinger, 2016-09-29 11:35:07]

+1 from my end. I like it.

[jgruber, 2016-09-29 14:44:24]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 14:44:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 14:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 14:47:38]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9937)

[Yang, 2016-10-04 11:34:25]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-10-04 11:34:25]

src/{debug,regexp,snapshot}/* lgtm.

[Michael Starzinger, 2016-10-07 09:32:56]

LGTM (reviewed objects files, rubber-stamped the rest).

[ahaas, 2016-10-07 09:36:58]

On 2016/10/07 at 09:32:56, mstarzinger wrote:
> LGTM (reviewed objects files, rubber-stamped the rest).

wasm lgtm

[jgruber, 2016-10-07 10:32:15]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-10-07 10:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, yangguo@chromium.org, ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2381843002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-07 10:32:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 10:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:39:31]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25919)

[Benedikt Meurer, 2016-10-07 10:46:20]

LGTM (rubber-stamped)

[jgruber, 2016-10-07 10:47:12]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:47:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 11:03:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-07 11:03:51]

Description was changed from

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=
==========

to

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

[commit-bot: I haz the power, 2016-10-07 11:03:53]

Patchset 3 (id:??) landed as
https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}

[jgruber, 2016-10-07 12:10:23]

Description was changed from

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

to

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

[jgruber, 2016-10-07 12:11:11]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 12:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 12:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 12:13:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/14163)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/10366)

[jgruber, 2016-10-07 12:29:20]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 12:29:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 12:57:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 12:57:33]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-10-07 13:01:11]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-10-07 13:01:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org, yangguo@chromium.org,
ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2381843002/#ps80001
(title: "Mark Smi::kZero as V8_EXPORT_PRIVATE")

[commit-bot: I haz the power, 2016-10-07 13:01:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 13:05:15]

Description was changed from

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

to

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

[commit-bot: I haz the power, 2016-10-07 13:05:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-07 13:05:36]

Description was changed from

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Cr-Commit-Position: refs/heads/master@{#40080}
==========

to

==========
Add Smi::Zero and replace all Smi::FromInt(0) calls

BUG=

Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020
Committed: https://crrev.com/9ef4c3af2502d2f6757ffc0c0ff67242d49f7521
Cr-Original-Commit-Position: refs/heads/master@{#40080}
Cr-Commit-Position: refs/heads/master@{#40087}
==========

[commit-bot: I haz the power, 2016-10-07 13:05:38]

Patchset 5 (id:??) landed as
https://crrev.com/9ef4c3af2502d2f6757ffc0c0ff67242d49f7521
Cr-Commit-Position: refs/heads/master@{#40087}