src/elements.cc - Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)

Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.cc

diff --git a/src/elements.cc b/src/elements.cc

index fb73d6c24c836d5d3098ec545f1a78056d578578..83733cb835d3883fd3617e25f0655cc6ebad2e65 100644

--- a/src/elements.cc

+++ b/src/elements.cc

@@ -1970,7 +1970,7 @@ class FastElementsAccessor : public ElementsAccessorBase<Subclass, KindTraits> {

if (new_length == 0) {

receiver->set_elements(heap->empty_fixed_array());

- receiver->set_length(Smi::FromInt(0));

+ receiver->set_length(Smi::kZero);

return isolate->factory()->NewJSArrayWithElements(

backing_store, KindTraits::Kind, delete_count);

}

« no previous file with comments | « src/deoptimizer.cc ('k') | src/factory.cc » ('j') | no next file with comments »