Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)
Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/unittests/interpreter/bytecode-array-builder-unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/interpreter/bytecode-array-builder.h" 7 #include "src/interpreter/bytecode-array-builder.h"
8 #include "src/interpreter/bytecode-array-iterator.h" 8 #include "src/interpreter/bytecode-array-iterator.h"
9 #include "test/unittests/test-utils.h" 9 #include "test/unittests/test-utils.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 namespace interpreter { 13 namespace interpreter {
14 14
15 class BytecodeArrayIteratorTest : public TestWithIsolateAndZone { 15 class BytecodeArrayIteratorTest : public TestWithIsolateAndZone {
16 public: 16 public:
17 BytecodeArrayIteratorTest() {} 17 BytecodeArrayIteratorTest() {}
18 ~BytecodeArrayIteratorTest() override {} 18 ~BytecodeArrayIteratorTest() override {}
19 }; 19 };
20 20
21 21
22 TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) { 22 TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {
23 // Use a builder to create an array with containing multiple bytecodes 23 // Use a builder to create an array with containing multiple bytecodes
24 // with 0, 1 and 2 operands. 24 // with 0, 1 and 2 operands.
25 BytecodeArrayBuilder builder(isolate(), zone(), 3, 3, 0); 25 BytecodeArrayBuilder builder(isolate(), zone(), 3, 3, 0);
26 Factory* factory = isolate()->factory(); 26 Factory* factory = isolate()->factory();
27 Handle<HeapObject> heap_num_0 = factory->NewHeapNumber(2.718); 27 Handle<HeapObject> heap_num_0 = factory->NewHeapNumber(2.718);
28 Handle<HeapObject> heap_num_1 = factory->NewHeapNumber(2147483647); 28 Handle<HeapObject> heap_num_1 = factory->NewHeapNumber(2147483647);
29 Smi* zero = Smi::FromInt(0); 29 Smi* zero = Smi::kZero;
30 Smi* smi_0 = Smi::FromInt(64); 30 Smi* smi_0 = Smi::FromInt(64);
31 Smi* smi_1 = Smi::FromInt(-65536); 31 Smi* smi_1 = Smi::FromInt(-65536);
32 Register reg_0(0); 32 Register reg_0(0);
33 Register reg_1(1); 33 Register reg_1(1);
34 RegisterList pair(0, 2); 34 RegisterList pair(0, 2);
35 RegisterList triple(0, 3); 35 RegisterList triple(0, 3);
36 Register param = Register::FromParameterIndex(2, builder.parameter_count()); 36 Register param = Register::FromParameterIndex(2, builder.parameter_count());
37 Handle<String> name = factory->NewStringFromStaticChars("abc"); 37 Handle<String> name = factory->NewStringFromStaticChars("abc");
38 int name_index = 2; 38 int name_index = 2;
39 int feedback_slot = 97; 39 int feedback_slot = 97;
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 CHECK_EQ(iterator.current_offset(), offset); 278 CHECK_EQ(iterator.current_offset(), offset);
279 CHECK_EQ(iterator.current_operand_scale(), OperandScale::kSingle); 279 CHECK_EQ(iterator.current_operand_scale(), OperandScale::kSingle);
280 CHECK(!iterator.done()); 280 CHECK(!iterator.done());
281 iterator.Advance(); 281 iterator.Advance();
282 CHECK(iterator.done()); 282 CHECK(iterator.done());
283 } 283 }
284 284
285 } // namespace interpreter 285 } // namespace interpreter
286 } // namespace internal 286 } // namespace internal
287 } // namespace v8 287 } // namespace v8
OLDNEW
« no previous file with comments | « test/unittests/interpreter/bytecode-array-builder-unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698