src/crankshaft/lithium-codegen.cc - Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium-codegen.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)

Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/lithium-codegen.cc

diff --git a/src/crankshaft/lithium-codegen.cc b/src/crankshaft/lithium-codegen.cc

index decc2a596f9f37684e6951fc442b4d6af1a4be93..7e2333f558b18200160b6c40bb36cdc7564c4abc 100644

--- a/src/crankshaft/lithium-codegen.cc

+++ b/src/crankshaft/lithium-codegen.cc

@@ -328,9 +328,9 @@ void LCodeGenBase::PopulateDeoptimizationData(Handle<Code> code) {

AllowDeferredHandleDereference allow_handle_dereference;

data->SetSharedFunctionInfo(*info_->shared_info());

} else {

- data->SetSharedFunctionInfo(Smi::FromInt(0));

+ data->SetSharedFunctionInfo(Smi::kZero);

}

- data->SetWeakCellCache(Smi::FromInt(0));

+ data->SetWeakCellCache(Smi::kZero);

Handle<FixedArray> literals =

factory()->NewFixedArray(deoptimization_literals_.length(), TENURED);