src/ast/scopeinfo.cc - Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/scopeinfo.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)

Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/scopeinfo.cc

diff --git a/src/ast/scopeinfo.cc b/src/ast/scopeinfo.cc

index 5354b8d737800c4ac2cd57d6fc4b3e6ffd8dd9e4..5d0212c750b5916c1d95de1da83f9692a9f47643 100644

--- a/src/ast/scopeinfo.cc

+++ b/src/ast/scopeinfo.cc

@@ -315,7 +315,7 @@ Handle<ScopeInfo> ScopeInfo::CreateForWithScope(

int index = kVariablePartIndex;

DCHECK_EQ(index, scope_info->ParameterNamesIndex());

DCHECK_EQ(index, scope_info->StackLocalFirstSlotIndex());

- scope_info->set(index++, Smi::FromInt(0));

+ scope_info->set(index++, Smi::kZero);

DCHECK_EQ(index, scope_info->StackLocalNamesIndex());

DCHECK_EQ(index, scope_info->ReceiverInfoIndex());

DCHECK_EQ(index, scope_info->FunctionNameInfoIndex());

« no previous file with comments | « src/ast/ast.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »