Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: src/ppc/macro-assembler-ppc.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)
Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | src/property.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ppc/macro-assembler-ppc.cc
diff --git a/src/ppc/macro-assembler-ppc.cc b/src/ppc/macro-assembler-ppc.cc
index 9b5f80ebe980a6b7c106750f5b885c55761b43a4..bbc08e87f01ab29c36e8634297352a0278694341 100644
--- a/src/ppc/macro-assembler-ppc.cc
+++ b/src/ppc/macro-assembler-ppc.cc
@@ -3451,7 +3451,7 @@ void MacroAssembler::EmitSeqStringSetCharCheck(Register string, Register index,
cmp(index, ip);
Check(lt, kIndexIsTooLarge);
- DCHECK(Smi::FromInt(0) == 0);
+ DCHECK(Smi::kZero == 0);
cmpi(index, Operand::Zero());
Check(ge, kIndexIsNegative);
@@ -3828,7 +3828,7 @@ void MacroAssembler::CheckEnumCache(Label* call_runtime) {
// For all objects but the receiver, check that the cache is empty.
EnumLength(r6, r4);
- CmpSmiLiteral(r6, Smi::FromInt(0), r0);
+ CmpSmiLiteral(r6, Smi::kZero, r0);
bne(call_runtime);
bind(&start);
« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698