src/builtins/builtins-regexp.cc - Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-regexp.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)

Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-regexp.cc

diff --git a/src/builtins/builtins-regexp.cc b/src/builtins/builtins-regexp.cc

index 554887b7dda31ba1d34dc1af0358ddf2b0dd3b2e..a121a951c9da4abf6ca8d99fed8c4e6545592e99 100644

--- a/src/builtins/builtins-regexp.cc

+++ b/src/builtins/builtins-regexp.cc

@@ -322,7 +322,7 @@ void Builtins::Generate_RegExpPrototypeExec(CodeStubAssembler* a) {

Node* const null = a->NullConstant();

Node* const int_zero = a->IntPtrConstant(0);

- Node* const smi_zero = a->SmiConstant(Smi::FromInt(0));

+ Node* const smi_zero = a->SmiConstant(Smi::kZero);

// Ensure {receiver} is a JSRegExp.

Node* const regexp_map = a->ThrowIfNotInstanceType(

« no previous file with comments | « src/builtins/builtins-math.cc ('k') | src/builtins/builtins-string.cc » ('j') | no next file with comments »