Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 2381843002: Add Smi::Zero and replace all Smi::FromInt(0) calls (Closed)
Patch Set: Mark Smi::kZero as V8_EXPORT_PRIVATE Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 4835 matching lines...) Expand 10 before | Expand all | Expand 10 after
4846 4846
4847 // Insert additional parameters into the stack frame above return address. 4847 // Insert additional parameters into the stack frame above return address.
4848 __ PopReturnAddressTo(scratch); 4848 __ PopReturnAddressTo(scratch);
4849 __ Push(receiver); 4849 __ Push(receiver);
4850 __ Push(FieldOperand(callback, AccessorInfo::kDataOffset)); 4850 __ Push(FieldOperand(callback, AccessorInfo::kDataOffset));
4851 __ LoadRoot(kScratchRegister, Heap::kUndefinedValueRootIndex); 4851 __ LoadRoot(kScratchRegister, Heap::kUndefinedValueRootIndex);
4852 __ Push(kScratchRegister); // return value 4852 __ Push(kScratchRegister); // return value
4853 __ Push(kScratchRegister); // return value default 4853 __ Push(kScratchRegister); // return value default
4854 __ PushAddress(ExternalReference::isolate_address(isolate())); 4854 __ PushAddress(ExternalReference::isolate_address(isolate()));
4855 __ Push(holder); 4855 __ Push(holder);
4856 __ Push(Smi::FromInt(0)); // should_throw_on_error -> false 4856 __ Push(Smi::kZero); // should_throw_on_error -> false
4857 __ Push(FieldOperand(callback, AccessorInfo::kNameOffset)); 4857 __ Push(FieldOperand(callback, AccessorInfo::kNameOffset));
4858 __ PushReturnAddressFrom(scratch); 4858 __ PushReturnAddressFrom(scratch);
4859 4859
4860 // v8::PropertyCallbackInfo::args_ array and name handle. 4860 // v8::PropertyCallbackInfo::args_ array and name handle.
4861 const int kStackUnwindSpace = PropertyCallbackArguments::kArgsLength + 1; 4861 const int kStackUnwindSpace = PropertyCallbackArguments::kArgsLength + 1;
4862 4862
4863 // Allocate v8::PropertyCallbackInfo in non-GCed stack space. 4863 // Allocate v8::PropertyCallbackInfo in non-GCed stack space.
4864 const int kArgStackSpace = 1; 4864 const int kArgStackSpace = 1;
4865 4865
4866 // Load address of v8::PropertyAccessorInfo::args_ array. 4866 // Load address of v8::PropertyAccessorInfo::args_ array.
(...skipping 28 matching lines...) Expand all
4895 kStackUnwindSpace, nullptr, return_value_operand, 4895 kStackUnwindSpace, nullptr, return_value_operand,
4896 NULL); 4896 NULL);
4897 } 4897 }
4898 4898
4899 #undef __ 4899 #undef __
4900 4900
4901 } // namespace internal 4901 } // namespace internal
4902 } // namespace v8 4902 } // namespace v8
4903 4903
4904 #endif // V8_TARGET_ARCH_X64 4904 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698