Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. According to new store IC calling convention the value, slot and vector are passed on the stack and there's no need in trying to preserve values or respective registers in store handlers. Nice bonus: we also don't need virtual registers anymore. BUG=v8:5407 Committed: https://crrev.com/49695346ae3f09dcbfe8ed127788a8827233cee0 Cr-Commit-Position: refs/heads/master@{#39672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -323 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 18 chunks +30 lines, -72 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +12 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 3 chunks +16 lines, -9 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 4 chunks +25 lines, -32 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 4 chunks +25 lines, -32 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 3 chunks +7 lines, -22 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 18 chunks +30 lines, -72 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (18 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-22 09:01:32 UTC) #6
mvstanton
LGTM thanks for retiring the virtual register! :D
4 years, 3 months ago (2016-09-23 11:14:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357323003/20001
4 years, 3 months ago (2016-09-23 11:33:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357323003/20001
4 years, 3 months ago (2016-09-23 11:52:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357323003/20001
4 years, 3 months ago (2016-09-23 13:11:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357323003/20001
4 years, 3 months ago (2016-09-23 14:10:52 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-23 14:29:15 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 14:29:28 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49695346ae3f09dcbfe8ed127788a8827233cee0
Cr-Commit-Position: refs/heads/master@{#39672}

Powered by Google App Engine
This is Rietveld 408576698