Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 607 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
608 // Call the runtime system to load the interceptor. 608 // Call the runtime system to load the interceptor.
609 DCHECK(holder()->HasNamedInterceptor()); 609 DCHECK(holder()->HasNamedInterceptor());
610 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 610 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
611 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 611 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
612 holder()); 612 holder());
613 613
614 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 614 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
615 } 615 }
616 616
617 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
618 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
619 }
617 620
618 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 621 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
619 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 622 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
620 LanguageMode language_mode) { 623 LanguageMode language_mode) {
621 Register holder_reg = Frontend(name); 624 Register holder_reg = Frontend(name);
622 625
623 __ push(receiver()); // receiver 626 __ push(receiver()); // receiver
624 __ push(holder_reg); 627 __ push(holder_reg);
625 628
626 // If the callback cannot leak, then push the callback directly, 629 // If the callback cannot leak, then push the callback directly,
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 // Return the generated code. 685 // Return the generated code.
683 return GetCode(kind(), name); 686 return GetCode(kind(), name);
684 } 687 }
685 688
686 689
687 #undef __ 690 #undef __
688 } // namespace internal 691 } // namespace internal
689 } // namespace v8 692 } // namespace v8
690 693
691 #endif // V8_TARGET_ARCH_ARM 694 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698