Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: src/ic/ppc/handler-compiler-ppc.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 602 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
603 // Call the runtime system to load the interceptor. 603 // Call the runtime system to load the interceptor.
604 DCHECK(holder()->HasNamedInterceptor()); 604 DCHECK(holder()->HasNamedInterceptor());
605 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 605 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
606 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 606 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
607 holder()); 607 holder());
608 608
609 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 609 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
610 } 610 }
611 611
612 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
613 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
614 }
612 615
613 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 616 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
614 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 617 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
615 LanguageMode language_mode) { 618 LanguageMode language_mode) {
616 Register holder_reg = Frontend(name); 619 Register holder_reg = Frontend(name);
617 620
618 __ Push(receiver(), holder_reg); // receiver 621 __ Push(receiver(), holder_reg); // receiver
619 622
620 // If the callback cannot leak, then push the callback directly, 623 // If the callback cannot leak, then push the callback directly,
621 // otherwise wrap it in a weak cell. 624 // otherwise wrap it in a weak cell.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 // Return the generated code. 679 // Return the generated code.
677 return GetCode(kind(), name); 680 return GetCode(kind(), name);
678 } 681 }
679 682
680 683
681 #undef __ 684 #undef __
682 } // namespace internal 685 } // namespace internal
683 } // namespace v8 686 } // namespace v8
684 687
685 #endif // V8_TARGET_ARCH_ARM 688 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698