Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ia32/stub-cache-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
593 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 593 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
594 // Call the runtime system to load the interceptor. 594 // Call the runtime system to load the interceptor.
595 DCHECK(holder()->HasNamedInterceptor()); 595 DCHECK(holder()->HasNamedInterceptor());
596 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 596 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
597 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 597 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
598 holder()); 598 holder());
599 599
600 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 600 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
601 } 601 }
602 602
603 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
604 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
605 }
603 606
604 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 607 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
605 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 608 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
606 LanguageMode language_mode) { 609 LanguageMode language_mode) {
607 Register holder_reg = Frontend(name); 610 Register holder_reg = Frontend(name);
608 611
609 __ Push(receiver(), holder_reg); // Receiver. 612 __ Push(receiver(), holder_reg); // Receiver.
610 // If the callback cannot leak, then push the callback directly, 613 // If the callback cannot leak, then push the callback directly,
611 // otherwise wrap it in a weak cell. 614 // otherwise wrap it in a weak cell.
612 if (callback->data()->IsUndefined(isolate()) || callback->data()->IsSmi()) { 615 if (callback->data()->IsUndefined(isolate()) || callback->data()->IsSmi()) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 // Return the generated code. 670 // Return the generated code.
668 return GetCode(kind(), name); 671 return GetCode(kind(), name);
669 } 672 }
670 673
671 674
672 #undef __ 675 #undef __
673 } // namespace internal 676 } // namespace internal
674 } // namespace v8 677 } // namespace v8
675 678
676 #endif // V8_TARGET_ARCH_MIPS 679 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ia32/stub-cache-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698