[fullcodegen] Refactor code that calls store ICs.

[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
Committed: https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b
Cr-Commit-Position: refs/heads/master@{#39679}

[Igor Sheludko, 2016-09-22 15:43:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 15:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 15:53:33]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Igor Sheludko, 2016-09-23 07:52:46]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-09-23 07:54:54]

Description was changed from

==========
[fullcodegen] Load slot and name in FCG::CallStoreIC() and slot in
FCG::CallKeyedStoreIC().

BUG=v8:5407
==========

to

==========
[fullcodegen] Load slot and name in FCG::CallStoreIC() and slot in
FCG::CallKeyedStoreIC().

BUG=v8:5407
==========

[Igor Sheludko, 2016-09-23 07:55:02]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 07:55:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-23 09:01:28]

Description was changed from

==========
[fullcodegen] Load slot and name in FCG::CallStoreIC() and slot in
FCG::CallKeyedStoreIC().

BUG=v8:5407
==========

to

==========
[fullcodegen] Refactor the code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

[Igor Sheludko, 2016-09-23 09:02:15]

Description was changed from

==========
[fullcodegen] Refactor the code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

to

==========
[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

[Igor Sheludko, 2016-09-23 09:02:47]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-09-23 09:02:48]

PTAL

[commit-bot: I haz the power, 2016-09-23 09:55:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:55:43]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build
URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[mvstanton, 2016-09-23 11:16:55]

lgtm

[Igor Sheludko, 2016-09-23 15:57:29]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-09-23 15:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:00:15]

Description was changed from

==========
[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

to

==========
[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

[commit-bot: I haz the power, 2016-09-23 16:00:18]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-23 16:00:31]

Description was changed from

==========
[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407
==========

to

==========
[fullcodegen] Refactor code that calls store ICs.

Make FCG::CallStoreIC() load slot and name and make FCG::CallKeyedStoreIC() load
slot according to store IC calling convention (StoreDescriptor).

BUG=v8:5407

Committed: https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b
Cr-Commit-Position: refs/heads/master@{#39679}
==========

[commit-bot: I haz the power, 2016-09-23 16:00:32]

Patchset 1 (id:??) landed as
https://crrev.com/12918397b4af7b2bede8b29e1e9b1940d5d5ad3b
Cr-Commit-Position: refs/heads/master@{#39679}

[Michael Achenbach, 2016-09-23 17:05:36]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2363123002/ by machenbach@chromium.org.

The reason for reverting is: race suspect:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11893.