Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: src/ic/x87/ic-compiler-x87.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x87/handler-compiler-x87.cc ('k') | src/ic/x87/ic-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ic/ic.h" 7 #include "src/ic/ic.h"
8 #include "src/ic/ic-compiler.h" 8 #include "src/ic/ic-compiler.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 #define __ ACCESS_MASM(masm) 13 #define __ ACCESS_MASM(masm)
14 14
15 15
16 void PropertyICCompiler::GenerateRuntimeSetProperty( 16 void PropertyICCompiler::GenerateRuntimeSetProperty(
17 MacroAssembler* masm, LanguageMode language_mode) { 17 MacroAssembler* masm, LanguageMode language_mode) {
18 STATIC_ASSERT(StoreWithVectorDescriptor::kStackArgumentsCount == 3); 18 typedef StoreWithVectorDescriptor Descriptor;
19 // Current stack layout: 19 STATIC_ASSERT(Descriptor::kStackArgumentsCount == 3);
20 // - esp[12] -- value 20 // ----------- S t a t e -------------
21 // - esp[8] -- slot 21 // -- esp[12] : value
22 // - esp[4] -- vector 22 // -- esp[8] : slot
23 // - esp[0] -- return address 23 // -- esp[4] : vector
24 // -- esp[0] : return address
25 // -----------------------------------
26 __ LoadParameterFromStack<Descriptor>(Descriptor::ValueRegister(),
27 Descriptor::kValue);
24 28
25 __ mov(Operand(esp, 12), StoreDescriptor::ReceiverRegister()); 29 __ mov(Operand(esp, 12), Descriptor::ReceiverRegister());
26 __ mov(Operand(esp, 8), StoreDescriptor::NameRegister()); 30 __ mov(Operand(esp, 8), Descriptor::NameRegister());
27 __ mov(Operand(esp, 4), StoreDescriptor::ValueRegister()); 31 __ mov(Operand(esp, 4), Descriptor::ValueRegister());
28 __ pop(ebx); 32 __ pop(ebx);
29 __ push(Immediate(Smi::FromInt(language_mode))); 33 __ push(Immediate(Smi::FromInt(language_mode)));
30 __ push(ebx); // return address 34 __ push(ebx); // return address
31 35
32 // Do tail-call to runtime routine. 36 // Do tail-call to runtime routine.
33 __ TailCallRuntime(Runtime::kSetProperty); 37 __ TailCallRuntime(Runtime::kSetProperty);
34 } 38 }
35 39
36 40
37 #undef __ 41 #undef __
38 } // namespace internal 42 } // namespace internal
39 } // namespace v8 43 } // namespace v8
40 44
41 #endif // V8_TARGET_ARCH_X87 45 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/ic/x87/handler-compiler-x87.cc ('k') | src/ic/x87/ic-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698