[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through the stack.

[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407
Committed: https://crrev.com/76cfb388de91fa33c32d09bd9b16366154f25adf
Cr-Commit-Position: refs/heads/master@{#39617}

[Igor Sheludko, 2016-09-22 07:29:39]

Description was changed from

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

BUG=v8:5407
==========

to

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407
==========

[Igor Sheludko, 2016-09-22 07:29:44]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 07:29:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-22 07:29:58]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-09-22 07:29:59]

PTAL

[mvstanton, 2016-09-22 08:06:25]

I like the careful asserting!

https://codereview.chromium.org/2357163003/diff/1/src/full-codegen/full-codeg...
File src/full-codegen/full-codegen.cc (right):

https://codereview.chromium.org/2357163003/diff/1/src/full-codegen/full-codeg...
src/full-codegen/full-codegen.cc:246: }
Would it be better to push these values directly onto the stack, instead of
loading them into registers and then pushing?

[commit-bot: I haz the power, 2016-09-22 08:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:20:10]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-09-22 08:32:28]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-09-22 08:32:29]

LGTM.

[mvstanton, 2016-09-22 08:33:58]

Per your offline message addressing my comment: "let me address the "push slot
register" comment in a follow-up cl."

Okay. :)

LGTM.

[Igor Sheludko, 2016-09-22 08:41:09]

https://codereview.chromium.org/2357163003/diff/1/src/full-codegen/full-codeg...
File src/full-codegen/full-codegen.cc (right):

https://codereview.chromium.org/2357163003/diff/1/src/full-codegen/full-codeg...
src/full-codegen/full-codegen.cc:246: }
On 2016/09/22 08:06:24, mvstanton wrote:
> Would it be better to push these values directly onto the stack, instead of
> loading them into registers and then pushing?

Yes it would. Let me address this in a follow-up CL.

[Igor Sheludko, 2016-09-22 08:41:16]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:41:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 08:43:56]

Description was changed from

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407
==========

to

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407
==========

[commit-bot: I haz the power, 2016-09-22 08:43:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 08:44:12]

Description was changed from

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407
==========

to

==========
[ic][ia32][x87] Pass value, slot and vector to StoreIC and KeyedStoreIC through
the stack.

The handlers cleanup will be done in a follow-up CL.

BUG=v8:5407

Committed: https://crrev.com/76cfb388de91fa33c32d09bd9b16366154f25adf
Cr-Commit-Position: refs/heads/master@{#39617}
==========

[commit-bot: I haz the power, 2016-09-22 08:44:13]

Patchset 1 (id:??) landed as
https://crrev.com/76cfb388de91fa33c32d09bd9b16366154f25adf
Cr-Commit-Position: refs/heads/master@{#39617}