Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 630 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 641 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
642 // Call the runtime system to load the interceptor. 642 // Call the runtime system to load the interceptor.
643 DCHECK(holder()->HasNamedInterceptor()); 643 DCHECK(holder()->HasNamedInterceptor());
644 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 644 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
645 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 645 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
646 holder()); 646 holder());
647 647
648 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 648 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
649 } 649 }
650 650
651 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
652 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
653 }
651 654
652 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 655 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
653 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 656 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
654 LanguageMode language_mode) { 657 LanguageMode language_mode) {
655 ASM_LOCATION("NamedStoreHandlerCompiler::CompileStoreCallback"); 658 ASM_LOCATION("NamedStoreHandlerCompiler::CompileStoreCallback");
656 Register holder_reg = Frontend(name); 659 Register holder_reg = Frontend(name);
657 660
658 // Stub never generated for non-global objects that require access checks. 661 // Stub never generated for non-global objects that require access checks.
659 DCHECK(holder()->IsJSGlobalProxy() || !holder()->IsAccessCheckNeeded()); 662 DCHECK(holder()->IsJSGlobalProxy() || !holder()->IsAccessCheckNeeded());
660 663
(...skipping 18 matching lines...) Expand all
679 // Return the generated code. 682 // Return the generated code.
680 return GetCode(kind(), name); 683 return GetCode(kind(), name);
681 } 684 }
682 685
683 686
684 #undef __ 687 #undef __
685 } // namespace internal 688 } // namespace internal
686 } // namespace v8 689 } // namespace v8
687 690
688 #endif // V8_TARGET_ARCH_IA32 691 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698