Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: src/ic/s390/handler-compiler-s390.cc

Issue 2357323003: [ic][ia32][x87] Don't push/pop value/slot/vector in store handlers. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 565 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) { 576 void NamedLoadHandlerCompiler::GenerateLoadInterceptor(Register holder_reg) {
577 // Call the runtime system to load the interceptor. 577 // Call the runtime system to load the interceptor.
578 DCHECK(holder()->HasNamedInterceptor()); 578 DCHECK(holder()->HasNamedInterceptor());
579 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate())); 579 DCHECK(!holder()->GetNamedInterceptor()->getter()->IsUndefined(isolate()));
580 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(), 580 PushInterceptorArguments(masm(), receiver(), holder_reg, this->name(),
581 holder()); 581 holder());
582 582
583 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor); 583 __ TailCallRuntime(Runtime::kLoadPropertyWithInterceptor);
584 } 584 }
585 585
586 void NamedStoreHandlerCompiler::ZapStackArgumentsRegisterAliases() {
587 STATIC_ASSERT(!StoreWithVectorDescriptor::kPassLastArgsOnStack);
588 }
589
586 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 590 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
587 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback, 591 Handle<JSObject> object, Handle<Name> name, Handle<AccessorInfo> callback,
588 LanguageMode language_mode) { 592 LanguageMode language_mode) {
589 Register holder_reg = Frontend(name); 593 Register holder_reg = Frontend(name);
590 594
591 __ Push(receiver(), holder_reg); // receiver 595 __ Push(receiver(), holder_reg); // receiver
592 596
593 // If the callback cannot leak, then push the callback directly, 597 // If the callback cannot leak, then push the callback directly,
594 // otherwise wrap it in a weak cell. 598 // otherwise wrap it in a weak cell.
595 if (callback->data()->IsUndefined(isolate()) || callback->data()->IsSmi()) { 599 if (callback->data()->IsUndefined(isolate()) || callback->data()->IsSmi()) {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 649
646 // Return the generated code. 650 // Return the generated code.
647 return GetCode(kind(), name); 651 return GetCode(kind(), name);
648 } 652 }
649 653
650 #undef __ 654 #undef __
651 } // namespace internal 655 } // namespace internal
652 } // namespace v8 656 } // namespace v8
653 657
654 #endif // V8_TARGET_ARCH_ARM 658 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698