Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
Reviewers:
haraken, dglazkov
CC:
aboxhall, aboxhall+watch_chromium.org, ajuma+watch_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtseng+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, Eric Willigers, f(malita), fs, gasubic, gyuyoung2, hongchan, jbroman, jchaffraix+rendering, je_julie, Justin Novosad, kouhei+svg_chromium.org, leviw+renderwatch, nektarios, nektar+watch_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rjwright, rwlbuis, Raymond Toy, Stephen Chennney, shans, nessy, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vcarbune.chromium, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace narrowPrecisionToFloat with clampTo<float> All narrowPrecisionToFloat does is call clampTo<float>, so lets just make the callers do that. We use clampTo directly all over so there's no reason to hide it. BUG=642096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/80b8874e2d461c93ead9740347aa6ca40011d0a2 Cr-Commit-Position: refs/heads/master@{#419086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -128 lines) Patch
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 8 chunks +25 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransform.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/IIRDSPKernel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/FloatConversion.h View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFKernel.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatPoint.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRect.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatSize.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/AffineTransform.cpp View 5 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
esprehn
4 years, 3 months ago (2016-09-16 02:25:31 UTC) #5
haraken
LGTM
4 years, 3 months ago (2016-09-16 02:31:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342913003/1
4 years, 3 months ago (2016-09-16 02:34:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 03:12:00 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 03:14:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80b8874e2d461c93ead9740347aa6ca40011d0a2
Cr-Commit-Position: refs/heads/master@{#419086}

Powered by Google App Engine
This is Rietveld 408576698