third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioParam.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index 24af794c3037d5967eea07a07b0568ca491d7ff4..79b2151d9eef084b6ad8e7a3eef0498a32de9b38 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -29,7 +29,6 @@

#include "modules/webaudio/AudioBufferSourceNode.h"

#include "modules/webaudio/AudioNodeOutput.h"

#include "modules/webaudio/BaseAudioContext.h"

-#include "platform/FloatConversion.h"

#include "platform/audio/AudioUtilities.h"

#include "wtf/MathExtras.h"

#include "wtf/PtrUtil.h"

@@ -315,7 +314,7 @@ bool AudioBufferSourceHandler::renderFromBuffer(AudioBus* bus, unsigned destinat

double sample2 = source[readIndex2];

double sample = (1.0 - interpolationFactor) * sample1 + interpolationFactor * sample2;

- destination[writeIndex] = narrowPrecisionToFloat(sample);

+ destination[writeIndex] = clampTo<float>(sample);

}

writeIndex++;