Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/platform/audio/HRTFKernel.cpp

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of 13 * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
14 * its contributors may be used to endorse or promote products derived 14 * its contributors may be used to endorse or promote products derived
15 * from this software without specific prior written permission. 15 * from this software without specific prior written permission.
16 * 16 *
17 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 17 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
18 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 18 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
19 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 19 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
20 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 20 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
21 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 21 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 22 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "platform/FloatConversion.h" 29 #include "platform/audio/HRTFKernel.h"
30
30 #include "platform/audio/AudioChannel.h" 31 #include "platform/audio/AudioChannel.h"
31 #include "platform/audio/HRTFKernel.h"
32 #include "wtf/MathExtras.h" 32 #include "wtf/MathExtras.h"
33 #include "wtf/PtrUtil.h" 33 #include "wtf/PtrUtil.h"
34 #include <algorithm> 34 #include <algorithm>
35 #include <memory> 35 #include <memory>
36 36
37 namespace blink { 37 namespace blink {
38 38
39 // Takes the input AudioChannel as an input impulse response and calculates the average group delay. 39 // Takes the input AudioChannel as an input impulse response and calculates the average group delay.
40 // This represents the initial delay before the most energetic part of the impul se response. 40 // This represents the initial delay before the most energetic part of the impul se response.
41 // The sample-frame delay is removed from the impulseP impulse response, and thi s value is returned. 41 // The sample-frame delay is removed from the impulseP impulse response, and thi s value is returned.
42 // the length of the passed in AudioChannel must be a power of 2. 42 // the length of the passed in AudioChannel must be a power of 2.
43 static float extractAverageGroupDelay(AudioChannel* channel, size_t analysisFFTS ize) 43 static float extractAverageGroupDelay(AudioChannel* channel, size_t analysisFFTS ize)
44 { 44 {
45 ASSERT(channel); 45 ASSERT(channel);
46 46
47 float* impulseP = channel->mutableData(); 47 float* impulseP = channel->mutableData();
48 48
49 bool isSizeGood = channel->length() >= analysisFFTSize; 49 bool isSizeGood = channel->length() >= analysisFFTSize;
50 ASSERT(isSizeGood); 50 ASSERT(isSizeGood);
51 if (!isSizeGood) 51 if (!isSizeGood)
52 return 0; 52 return 0;
53 53
54 // Check for power-of-2. 54 // Check for power-of-2.
55 ASSERT(1UL << static_cast<unsigned>(log2(analysisFFTSize)) == analysisFFTSiz e); 55 ASSERT(1UL << static_cast<unsigned>(log2(analysisFFTSize)) == analysisFFTSiz e);
56 56
57 FFTFrame estimationFrame(analysisFFTSize); 57 FFTFrame estimationFrame(analysisFFTSize);
58 estimationFrame.doFFT(impulseP); 58 estimationFrame.doFFT(impulseP);
59 59
60 float frameDelay = narrowPrecisionToFloat(estimationFrame.extractAverageGrou pDelay()); 60 float frameDelay = clampTo<float>(estimationFrame.extractAverageGroupDelay() );
61 estimationFrame.doInverseFFT(impulseP); 61 estimationFrame.doInverseFFT(impulseP);
62 62
63 return frameDelay; 63 return frameDelay;
64 } 64 }
65 65
66 HRTFKernel::HRTFKernel(AudioChannel* channel, size_t fftSize, float sampleRate) 66 HRTFKernel::HRTFKernel(AudioChannel* channel, size_t fftSize, float sampleRate)
67 : m_frameDelay(0) 67 : m_frameDelay(0)
68 , m_sampleRate(sampleRate) 68 , m_sampleRate(sampleRate)
69 { 69 {
70 ASSERT(channel); 70 ASSERT(channel);
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return nullptr; 121 return nullptr;
122 122
123 float frameDelay = (1 - x) * kernel1->frameDelay() + x * kernel2->frameDelay (); 123 float frameDelay = (1 - x) * kernel1->frameDelay() + x * kernel2->frameDelay ();
124 124
125 std::unique_ptr<FFTFrame> interpolatedFrame = FFTFrame::createInterpolatedFr ame(*kernel1->fftFrame(), *kernel2->fftFrame(), x); 125 std::unique_ptr<FFTFrame> interpolatedFrame = FFTFrame::createInterpolatedFr ame(*kernel1->fftFrame(), *kernel2->fftFrame(), x);
126 return HRTFKernel::create(std::move(interpolatedFrame), frameDelay, sampleRa te1); 126 return HRTFKernel::create(std::move(interpolatedFrame), frameDelay, sampleRa te1);
127 } 127 }
128 128
129 } // namespace blink 129 } // namespace blink
130 130
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/FloatConversion.h ('k') | third_party/WebKit/Source/platform/geometry/FloatPoint.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698