Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y 16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N 19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #include "modules/webaudio/BiquadDSPKernel.h" 25 #include "modules/webaudio/BiquadDSPKernel.h"
26 #include "platform/FloatConversion.h"
27 #include "platform/audio/AudioUtilities.h" 26 #include "platform/audio/AudioUtilities.h"
27 #include "wtf/MathExtras.h"
28 #include "wtf/Vector.h" 28 #include "wtf/Vector.h"
29 #include <limits.h> 29 #include <limits.h>
30 30
31 namespace blink { 31 namespace blink {
32 32
33 // FIXME: As a recursive linear filter, depending on its parameters, a biquad fi lter can have 33 // FIXME: As a recursive linear filter, depending on its parameters, a biquad fi lter can have
34 // an infinite tailTime. In practice, Biquad filters do not usually (except for very high resonance values) 34 // an infinite tailTime. In practice, Biquad filters do not usually (except for very high resonance values)
35 // have a tailTime of longer than approx. 200ms. This value could possibly be ca lculated based on the 35 // have a tailTime of longer than approx. 200ms. This value could possibly be ca lculated based on the
36 // settings of the Biquad. 36 // settings of the Biquad.
37 static const double MaxBiquadDelayTime = 0.2; 37 static const double MaxBiquadDelayTime = 0.2;
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 if (!isGood) 142 if (!isGood)
143 return; 143 return;
144 144
145 Vector<float> frequency(nFrequencies); 145 Vector<float> frequency(nFrequencies);
146 146
147 double nyquist = this->nyquist(); 147 double nyquist = this->nyquist();
148 148
149 // Convert from frequency in Hz to normalized frequency (0 -> 1), 149 // Convert from frequency in Hz to normalized frequency (0 -> 1),
150 // with 1 equal to the Nyquist frequency. 150 // with 1 equal to the Nyquist frequency.
151 for (int k = 0; k < nFrequencies; ++k) 151 for (int k = 0; k < nFrequencies; ++k)
152 frequency[k] = narrowPrecisionToFloat(frequencyHz[k] / nyquist); 152 frequency[k] = clampTo<float>(frequencyHz[k] / nyquist);
153 153
154 float cutoffFrequency; 154 float cutoffFrequency;
155 float Q; 155 float Q;
156 float gain; 156 float gain;
157 float detune; // in Cents 157 float detune; // in Cents
158 158
159 { 159 {
160 // Get a copy of the current biquad filter coefficients so we can update the biquad with 160 // Get a copy of the current biquad filter coefficients so we can update the biquad with
161 // these values. We need to synchronize with process() to prevent proces s() from updating 161 // these values. We need to synchronize with process() to prevent proces s() from updating
162 // the filter coefficients while we're trying to access them. The proces s will update it 162 // the filter coefficients while we're trying to access them. The proces s will update it
(...skipping 24 matching lines...) Expand all
187 return MaxBiquadDelayTime; 187 return MaxBiquadDelayTime;
188 } 188 }
189 189
190 double BiquadDSPKernel::latencyTime() const 190 double BiquadDSPKernel::latencyTime() const
191 { 191 {
192 return 0; 192 return 0;
193 } 193 }
194 194
195 } // namespace blink 195 } // namespace blink
196 196
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698