Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Side by Side Diff: third_party/WebKit/Source/platform/geometry/FloatPoint.cpp

Issue 2342913003: Replace narrowPrecisionToFloat with clampTo<float> (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2005 Nokia. All rights reserved. 3 * Copyright (C) 2005 Nokia. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "platform/geometry/FloatPoint.h" 27 #include "platform/geometry/FloatPoint.h"
28 28
29 #include "SkPoint.h" 29 #include "SkPoint.h"
30 #include "platform/FloatConversion.h"
31 #include "platform/geometry/DoublePoint.h" 30 #include "platform/geometry/DoublePoint.h"
32 #include "platform/geometry/LayoutPoint.h" 31 #include "platform/geometry/LayoutPoint.h"
33 #include "platform/geometry/LayoutSize.h" 32 #include "platform/geometry/LayoutSize.h"
33 #include "wtf/MathExtras.h"
34 #include "wtf/text/WTFString.h" 34 #include "wtf/text/WTFString.h"
35 #include <limits> 35 #include <limits>
36 #include <math.h> 36 #include <math.h>
37 37
38 namespace blink { 38 namespace blink {
39 39
40 // Skia has problems when passed infinite, etc floats, filter them to 0. 40 // Skia has problems when passed infinite, etc floats, filter them to 0.
41 static inline SkScalar WebCoreFloatToSkScalar(float f) 41 static inline SkScalar WebCoreFloatToSkScalar(float f)
42 { 42 {
43 return SkFloatToScalar(std::isfinite(f) ? f : 0); 43 return SkFloatToScalar(std::isfinite(f) ? f : 0);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 } 85 }
86 86
87 SkPoint FloatPoint::data() const 87 SkPoint FloatPoint::data() const
88 { 88 {
89 SkPoint p = { WebCoreFloatToSkScalar(m_x), WebCoreFloatToSkScalar(m_y) }; 89 SkPoint p = { WebCoreFloatToSkScalar(m_x), WebCoreFloatToSkScalar(m_y) };
90 return p; 90 return p;
91 } 91 }
92 92
93 FloatPoint FloatPoint::narrowPrecision(double x, double y) 93 FloatPoint FloatPoint::narrowPrecision(double x, double y)
94 { 94 {
95 return FloatPoint(narrowPrecisionToFloat(x), narrowPrecisionToFloat(y)); 95 return FloatPoint(clampTo<float>(x), clampTo<float>(y));
96 } 96 }
97 97
98 bool findIntersection(const FloatPoint& p1, const FloatPoint& p2, const FloatPoi nt& d1, const FloatPoint& d2, FloatPoint& intersection) 98 bool findIntersection(const FloatPoint& p1, const FloatPoint& p2, const FloatPoi nt& d1, const FloatPoint& d2, FloatPoint& intersection)
99 { 99 {
100 float pxLength = p2.x() - p1.x(); 100 float pxLength = p2.x() - p1.x();
101 float pyLength = p2.y() - p1.y(); 101 float pyLength = p2.y() - p1.y();
102 102
103 float dxLength = d2.x() - d1.x(); 103 float dxLength = d2.x() - d1.x();
104 float dyLength = d2.y() - d1.y(); 104 float dyLength = d2.y() - d1.y();
105 105
106 float denom = pxLength * dyLength - pyLength * dxLength; 106 float denom = pxLength * dyLength - pyLength * dxLength;
107 if (!denom) 107 if (!denom)
108 return false; 108 return false;
109 109
110 float param = ((d1.x() - p1.x()) * dyLength - (d1.y() - p1.y()) * dxLength) / denom; 110 float param = ((d1.x() - p1.x()) * dyLength - (d1.y() - p1.y()) * dxLength) / denom;
111 111
112 intersection.setX(p1.x() + param * pxLength); 112 intersection.setX(p1.x() + param * pxLength);
113 intersection.setY(p1.y() + param * pyLength); 113 intersection.setY(p1.y() + param * pyLength);
114 return true; 114 return true;
115 } 115 }
116 116
117 String FloatPoint::toString() const 117 String FloatPoint::toString() const
118 { 118 {
119 return String::format("%lg,%lg", x(), y()); 119 return String::format("%lg,%lg", x(), y());
120 } 120 }
121 121
122 } // namespace blink 122 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/audio/HRTFKernel.cpp ('k') | third_party/WebKit/Source/platform/geometry/FloatRect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698