Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed: https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
Committed: https://skia.googlesource.com/skia/+/a624bf3d1cb454c1959c5bbbf23a3afdfa3481f3

[bsalomon, 2016-09-14 15:16:36]

Description was changed from

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
==========

to

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002
==========

[bsalomon, 2016-09-14 15:23:06]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-09-14 15:23:07]

I'd recommend looking at the GLSL processor base class headers first.

The next step is to move the texture/buffer accesses to use a similar model.

[robertphillips, 2016-09-15 20:44:31]

This is all I have from a first pass. I'm going to have to take a second look
though.

https://codereview.chromium.org/2339203002/diff/20001/include/gpu/GrFragmentP...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/2339203002/diff/20001/include/gpu/GrFragmentP...
include/gpu/GrFragmentProcessor.h:136: /**
or a the ?

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
File src/gpu/glsl/GrGLSLFragmentProcessor.h (right):

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
src/gpu/glsl/GrGLSLFragmentProcessor.h:37: * When building a program from a
GrPipeline this is used to provide the GrShaderVars that
the coords the resulting coords ?

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
src/gpu/glsl/GrGLSLFragmentProcessor.h:91: const char* inputColor,
const TransformedCoordVars& ?

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLProg...
File src/gpu/glsl/GrGLSLProgramBuilder.h (right):

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLProg...
src/gpu/glsl/GrGLSLProgramBuilder.h:10: 
Why do we need utility ?

[bsalomon, 2016-09-15 20:55:52]

https://codereview.chromium.org/2339203002/diff/20001/include/gpu/GrFragmentP...
File include/gpu/GrFragmentProcessor.h (right):

https://codereview.chromium.org/2339203002/diff/20001/include/gpu/GrFragmentP...
include/gpu/GrFragmentProcessor.h:136: /**
On 2016/09/15 20:44:30, robertphillips wrote:
> or a the ?

should be "or of the forest of FPs..."

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
File src/gpu/glsl/GrGLSLFragmentProcessor.h (right):

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
src/gpu/glsl/GrGLSLFragmentProcessor.h:37: * When building a program from a
GrPipeline this is used to provide the GrShaderVars that
On 2016/09/15 20:44:30, robertphillips wrote:
> the coords the resulting coords ?

maybe will change to "contain the resulting transformed coords from..."

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLFrag...
src/gpu/glsl/GrGLSLFragmentProcessor.h:91: const char* inputColor,
On 2016/09/15 20:44:30, robertphillips wrote:
> const TransformedCoordVars& ?

Sure, it is just 2 ptrs, but no reason it can't be const&

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLProg...
File src/gpu/glsl/GrGLSLProgramBuilder.h (right):

https://codereview.chromium.org/2339203002/diff/20001/src/gpu/glsl/GrGLSLProg...
src/gpu/glsl/GrGLSLProgramBuilder.h:10: 
On 2016/09/15 20:44:30, robertphillips wrote:
> Why do we need utility ?

Hm, maybe at one point I had a std::unique_ptr in here but no longer. I probably
don't need GrCoordTransform.h either in here.

[robertphillips, 2016-09-16 15:01:48]

lgtm

[bsalomon, 2016-09-19 15:17:11]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-19 15:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2339203002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-19 15:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 15:37:00]

Description was changed from

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002
==========

to

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed:
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
==========

[commit-bot: I haz the power, 2016-09-19 15:37:01]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6

[bsalomon, 2016-09-19 16:26:22]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2351753002/ by bsalomon@google.com.

The reason for reverting is: Crashing blink
 https://codereview.chromium.org/2351743002/.

[bsalomon, 2016-09-20 15:29:18]

Description was changed from

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed:
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
==========

to

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed:
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
==========

[bsalomon, 2016-09-20 15:29:21]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-20 15:29:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2339203002/#ps60001
(title: "Fix issue of taking ref to a temporary")

[commit-bot: I haz the power, 2016-09-20 15:29:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 16:12:49]

Description was changed from

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed:
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
==========

to

==========
Stop flattening GrCoordTransforms in parent GrFragmentProcessors.

This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when
inserting transformations by GrGLSLPrimitiveProcessors.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002

Committed:
https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6
Committed:
https://skia.googlesource.com/skia/+/a624bf3d1cb454c1959c5bbbf23a3afdfa3481f3
==========

[commit-bot: I haz the power, 2016-09-20 16:12:50]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a624bf3d1cb454c1959c5bbbf23a3afdfa3481f3