|
[Password Generation] Use signatures for form matching
At this time, the form matching is based on form name and action. Action should have canonical form and be non-empty. We missed to prepare actions in some cases. So, even if we classified a field as suitable for password generation, we didn't show generation popup, because form matching failed. It should be fixed.
Since the server sends signatures of form and fields, it is more error-prone to match forms based on what server works with.
BUG= 582434
Committed: https://crrev.com/e10ec8251677a375303d28f8941b7609fde23623
Cr-Commit-Position: refs/heads/master@{#420043}
Total comments: 21
Total comments: 4
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+359 lines, -272 lines) |
Patch |
|
M |
chrome/renderer/autofill/password_generation_test_utils.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/content/public/cpp/autofill_types_struct_traits.h
|
View
|
|
1 chunk |
+4 lines, -8 lines |
0 comments
|
Download
|
|
M |
components/autofill/content/public/cpp/autofill_types_struct_traits.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/autofill/content/public/cpp/autofill_types_struct_traits_unittest.cc
|
View
|
|
3 chunks |
+7 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/autofill/content/public/interfaces/autofill_types.mojom
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/content/renderer/password_generation_agent.cc
|
View
|
1
2
3
4
5
|
4 chunks |
+20 lines, -16 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_download_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_download_manager_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_field.h
|
View
|
1
2
3
4
|
2 chunks |
+5 lines, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_field.cc
|
View
|
1
2
3
4
|
3 chunks |
+6 lines, -16 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_field_unittest.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_manager_unittest.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/autofill_metrics_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_field.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_structure.h
|
View
|
1
2
|
5 chunks |
+8 lines, -13 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_structure.cc
|
View
|
1
2
3
4
|
14 chunks |
+18 lines, -77 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/browser/form_structure_unittest.cc
|
View
|
|
4 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/BUILD.gn
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
A + |
components/autofill/core/common/DEPS
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/autofill_util.h
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/autofill_util.cc
|
View
|
|
1 chunk |
+27 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/form_field_data.h
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/form_field_data.cc
|
View
|
|
2 chunks |
+1 line, -23 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/form_field_data_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/autofill/core/common/password_form_generation_data.h
|
View
|
1
2
|
2 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
|
A |
components/autofill/core/common/signatures_util.h
|
View
|
1
2
3
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
|
A |
components/autofill/core/common/signatures_util.cc
|
View
|
1
2
|
1 chunk |
+107 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/browser_save_password_progress_logger.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_form_manager.cc
|
View
|
|
3 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_form_manager_unittest.cc
|
View
|
|
8 chunks |
+18 lines, -17 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_generation_manager.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -22 lines |
0 comments
|
Download
|
|
M |
components/password_manager/core/browser/password_generation_manager_unittest.cc
|
View
|
|
6 chunks |
+25 lines, -15 lines |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 50 (32 generated)
|