[Password Generation] Move canonical action computation from rendered to browser part

[Password Generation] Move canonical action computation from rendered to browser part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical action in PasswordGenerationAgent. If action is empty, we need document's origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes on Windows (crbug.com/645507), because document() might be null.

In this CL, we move action computation to browser side where we know the origin for sure.

BUG=582434, 645507
Committed: https://crrev.com/c1a3b16b2baf991280f7c42a8cd99a27bfa7d566
Cr-Commit-Position: refs/heads/master@{#418246}

[kolos1, 2016-09-12 10:24:13]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[kolos1, 2016-09-12 10:24:34]

The CQ bit was unchecked by kolos@chromium.org

[kolos1, 2016-09-12 10:24:55]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 10:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 10:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 10:30:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kolos1, 2016-09-12 14:02:08]

Description was changed from

==========
o

BUG=
==========

to

==========
[Password Generation] Move canonical action computation from rendered to browser
part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical
action in PasswordGenerationAgent. If action is empty, we need document's
origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes
on Windows (crbug.com/645507), because document() might be null. 

In this CL, we move action computation to browser side where we know the origin
for sure.

BUG=582434, 645507
==========

[kolos1, 2016-09-13 13:37:55]

kolos@chromium.org changed reviewers:
+ dvadym@chromium.org, vabr@chromium.org

[kolos1, 2016-09-13 13:37:56]

dvadym@chromium.org: Please review changes in 
password_generation_agent.cc
password_generation_manager.cc

vabr@chromium.org: Please review changes in 
password_generation_test_utils.cc

[vabr (Chromium), 2016-09-13 13:43:32]

Hi Maxim,
password_generation_test_utils.cc LGTM!
Vaclav

[dvadym, 2016-09-13 13:45:14]

LGTM

[kolos1, 2016-09-13 13:57:58]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:58:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:45:49]

Description was changed from

==========
[Password Generation] Move canonical action computation from rendered to browser
part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical
action in PasswordGenerationAgent. If action is empty, we need document's
origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes
on Windows (crbug.com/645507), because document() might be null. 

In this CL, we move action computation to browser side where we know the origin
for sure.

BUG=582434, 645507
==========

to

==========
[Password Generation] Move canonical action computation from rendered to browser
part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical
action in PasswordGenerationAgent. If action is empty, we need document's
origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes
on Windows (crbug.com/645507), because document() might be null. 

In this CL, we move action computation to browser side where we know the origin
for sure.

BUG=582434, 645507
==========

[commit-bot: I haz the power, 2016-09-13 14:45:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 14:47:20]

Description was changed from

==========
[Password Generation] Move canonical action computation from rendered to browser
part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical
action in PasswordGenerationAgent. If action is empty, we need document's
origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes
on Windows (crbug.com/645507), because document() might be null. 

In this CL, we move action computation to browser side where we know the origin
for sure.

BUG=582434, 645507
==========

to

==========
[Password Generation] Move canonical action computation from rendered to browser
part

In this CL (https://codereview.chromium.org/2320563002/), we compute a canonical
action in PasswordGenerationAgent. If action is empty, we need document's
origin. But "render_frame()->GetWebFrame()->document().baseURL()" causes crashes
on Windows (crbug.com/645507), because document() might be null.

In this CL, we move action computation to browser side where we know the origin
for sure.

BUG=582434, 645507

Committed: https://crrev.com/c1a3b16b2baf991280f7c42a8cd99a27bfa7d566
Cr-Commit-Position: refs/heads/master@{#418246}
==========

[commit-bot: I haz the power, 2016-09-13 14:47:21]

Patchset 2 (id:??) landed as
https://crrev.com/c1a3b16b2baf991280f7c42a8cd99a27bfa7d566
Cr-Commit-Position: refs/heads/master@{#418246}