[Password Generation] Use signatures for form matching

components/autofill/core/common/form_field_data.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/form_field_data.h"
 
 #include "base/pickle.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/common/autofill_util.h"

[Nico, 2016/09/09 16:29:23]

fwiw we generally discourage "util" files since they end up as dumping grounds.
Can you think of a more specific name?

 
 namespace autofill {
 
 namespace {
 
 // Increment this anytime pickle format is modified as well as provide
 // deserialization routine from previous kPickleVersion format.
 const int kPickleVersion = 6;
 
 void AddVectorToPickle(std::vector<base::string16> strings,
@@ skipping 323 matching lines @@
             << base::UTF16ToUTF8(field.value) << " " << field.form_control_type
             << " " << field.autocomplete_attribute << " " << field.placeholder
             << " " << field.max_length << " " << field.css_classes << " "
             << (field.is_autofilled ? "true" : "false") << " "
             << check_status_str << (field.is_focusable ? "true" : "false")
             << " " << (field.should_autocomplete ? "true" : "false") << " "
             << role_str << " " << field.text_direction << " "
             << field.properties_mask;
 }
 
-bool IsCheckable(const FormFieldData::CheckStatus& check_status) {
-  return check_status != FormFieldData::CheckStatus::NOT_CHECKABLE;
-}
-
-bool IsChecked(const FormFieldData::CheckStatus& check_status) {
-  return check_status == FormFieldData::CheckStatus::CHECKED;
-}
-
-void SetCheckStatus(FormFieldData* form_field_data,
-                    bool isCheckable,
-                    bool isChecked) {
-  if (isChecked) {
-    form_field_data->check_status = FormFieldData::CheckStatus::CHECKED;
-  } else {
-    if (isCheckable) {
-      form_field_data->check_status =
-          FormFieldData::CheckStatus::CHECKABLE_BUT_UNCHECKED;
-    } else {
-      form_field_data->check_status = FormFieldData::CheckStatus::NOT_CHECKABLE;
-    }
-  }
-}
-
 }  // namespace autofill