Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: components/autofill/core/common/password_form_generation_data.h

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_generation_data.h
diff --git a/components/autofill/core/common/password_form_generation_data.h b/components/autofill/core/common/password_form_generation_data.h
index 38910c904f34b6d612e3ab1eddb2dcb23257f077..d010d9a8ddb0b7185407b0dd7ac15e2c684c93b8 100644
--- a/components/autofill/core/common/password_form_generation_data.h
+++ b/components/autofill/core/common/password_form_generation_data.h
@@ -5,8 +5,11 @@
#ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_GENERATION_DATA_H_
#define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_GENERATION_DATA_H_
+#include <stdint.h>
+
#include "base/strings/string16.h"
#include "components/autofill/core/common/form_field_data.h"
+#include "components/autofill/core/common/signatures_util.h"
#include "url/gurl.h"
namespace autofill {
@@ -14,15 +17,13 @@ namespace autofill {
// Structure used for sending information from browser to renderer about on
// which fields password should be generated.
struct PasswordFormGenerationData {
- // The name of the form.
- base::string16 name;
-
- // The action target of the form; this URL consists of the scheme, host, port
- // and path; the rest is stripped.
- GURL action;
+ // The unique signature of form where password should be generated
+ // (see components/autofill/core/browser/form_structure.h).
+ FormSignature form_signature;
- // Field in which password should be generated.
- FormFieldData generation_field;
+ // The unique signature of field where password should be generated
+ // (see components/autofill/core/browser/autofill_field.h).
+ FieldSignature field_signature;
};
} // namespace autofill
« no previous file with comments | « components/autofill/core/common/form_field_data_unittest.cc ('k') | components/autofill/core/common/signatures_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698