components/autofill/content/public/cpp/autofill_types_struct_traits.cc - Issue 2318533002: [Password Generation] Use signatures for form matching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/public/cpp/autofill_types_struct_traits.cc

Issue 2318533002: [Password Generation] Use signatures for form matching (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/public/cpp/autofill_types_struct_traits.h ('k') | components/autofill/content/public/cpp/autofill_types_struct_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/public/cpp/autofill_types_struct_traits.cc

diff --git a/components/autofill/content/public/cpp/autofill_types_struct_traits.cc b/components/autofill/content/public/cpp/autofill_types_struct_traits.cc

index 3ea26e928f86cdba22a44a542b8cca81ea332c68..4b020779bdb95636d08d04cbfa6d146195891a31 100644

--- a/components/autofill/content/public/cpp/autofill_types_struct_traits.cc

+++ b/components/autofill/content/public/cpp/autofill_types_struct_traits.cc

@@ -513,10 +513,8 @@ bool StructTraits<mojom::PasswordFormGenerationDataDataView,

PasswordFormGenerationData>::

Read(mojom::PasswordFormGenerationDataDataView data,

PasswordFormGenerationData* out) {

- if (!data.ReadName(&out->name) || !data.ReadAction(&out->action) ||

- !data.ReadGenerationField(&out->generation_field))

- return false;

+ out->form_signature = data.form_signature();

+ out->field_signature = data.field_signature();

return true;

}